Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS SDK 3.0.0-preview2 uploads to App Store problem #163

Closed
jessicawang143143 opened this issue Aug 30, 2018 · 8 comments
Closed

iOS SDK 3.0.0-preview2 uploads to App Store problem #163

jessicawang143143 opened this issue Aug 30, 2018 · 8 comments
Labels

Comments

@jessicawang143143
Copy link

Description

I upgraded twilio sdk to 3.0.0-preview2. Everything worked fine until I tried to upload new build to App Store. I got two issues and kind of fixed the first one. I put the first one here as well for you might want to know.

First issue: is fixed after I delete file 'inject_credentials.sh'

734d30d4-d7a4-4b40-8b83-c0106eadfea8

Second issue: currently I am stuck here
ad9f9ecf-ab6e-4970-9479-6d75d0ce8632

Since I don't have camera usage in app , I tried to use twilio 2.0.6 to upload again and it worked.
I think it might be related to WebRTC, which has possibilities to ask permissions for Microphone or Camera.
Do you mind check that?

Steps to Reproduce

  1. Update twilio version in pod file and update pod
  2. Change all the related api changes
  3. Archive and upload to App Store

Versions

3.0.0-preview2 (August 28, 2018)

Xcode

Version 9.4.1 (9F2000)

@piyushtank
Copy link
Contributor

@jessicawang143143 Thank for reaching out. Yes, the the WebRTC library used by the 3.0.0-preview2 Voice SDK has Audio+Video both in it, and thats probably the reason why you are running into this issue. I apologize for the inconvenience.

We are working on building the Voice SDK with audio only variant of WebRTC where you should not see this problem. We aim to ship this fix in a few days. I will let you know when it is released.

Best,
Piyush

@bobiechen-twilio
Copy link
Contributor

Hi @jessicawang143143

Just writing to let you know that we are actively working on fixing the issue. CLIENT-5121 is the number for tracking the issue.

Thanks
-bobie

@bobiechen-twilio
Copy link
Contributor

Hi @jessicawang143143

We've just finished the release of 3.0.0-preview3 (changelog).

Although the fix for CLIENT-5121 is not included in this version, we've actually made some good progress of building audio-only variant of WebRTC library (kudos to @piyushtank) so that it no longer requires video related dependencies. We've also used the library and uploaded the application to the store and confirmed that the auto-validation system does not complain about NSCameraUsageDescription being missed in the plist.

Anyway, the inject_credentials.sh file has been removed from the framework bundle in preview2.

Thanks again for reporting the issue and we hope to get back to you with new updates.
-bobie

@maxannear
Copy link

Appreciate the hard work @bchen-twilio and @piyushtank. Exciting you've got it up to v67 of WebRTC

Looking forward to using it with our beta test group once its audio-only!

@idelgado idelgado added the bug label Sep 19, 2018
@bobiechen-twilio
Copy link
Contributor

Hi everyone,

We've just release the Voice iOS SDK 3.0.0-preview4 (changelog), which has the audio-only WebRTC and should no longer cause this issue when the app is uploaded or submitted for review. Please update and let us know how it goes.

Thanks!
-bobie

@jessicawang143143
Copy link
Author

Thank you for keep us updated about you progress. I will upgrade to preview4 and try to upload again.

@maxannear
Copy link

Thanks @bchen-twilio and @piyushtank. Its now working for us and we're testing it with our beta test group.

@bobiechen-twilio
Copy link
Contributor

Closing issue and since the original issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants