New PushKit delegate method for iOS 11 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idelgado
suggested changes
May 15, 2018
| @@ -167,14 +167,31 @@ class ViewController: UIViewController, PKPushRegistryDelegate, TVONotificationD | |||
| self.deviceTokenString = nil | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
I think this might be a copy/paste error of the comment.
idelgado
reviewed
May 15, 2018
| @@ -180,6 +180,10 @@ class ViewController: UIViewController, PKPushRegistryDelegate, TVONotificationD | |||
| self.deviceTokenString = nil | |||
| } | |||
|
|
|||
| /** | |||
| * Try using the `pushRegistry:didReceiveIncomingPushWithPayload:forType:withCompletionHandler:` method if | |||
| * your application is targeting iOS 11. This delegate method wil soon be deprecated by Apple. | |||
There was a problem hiding this comment.
This delegate method is deprecated by Apple.
According to the docs.
idelgado
reviewed
May 15, 2018
| @@ -188,6 +192,19 @@ class ViewController: UIViewController, PKPushRegistryDelegate, TVONotificationD | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * This is delegate method is available in iOS 11 and above. Call the completion handler once the | |||
There was a problem hiding this comment.
This delegate method is available on iOS 11 and above.
idelgado
approved these changes
May 15, 2018
idelgado
suggested changes
May 15, 2018
| @@ -188,6 +192,19 @@ class ViewController: UIViewController, PKPushRegistryDelegate, TVONotificationD | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * This is delegate method is available on iOS 11 and above. Call the completion handler once the | |||
idelgado
approved these changes
May 15, 2018
ceaglest
approved these changes
May 15, 2018
| * notification payload is passed to the `TwilioVoice.handleNotification()` method. | ||
| */ | ||
| func pushRegistry(_ registry: PKPushRegistry, didReceiveIncomingPushWith payload: PKPushPayload, for type: PKPushType, completion: @escaping () -> Void) { | ||
| NSLog("pushRegistry:didReceiveIncomingPushWithPayload:forType:completion:") |
There was a problem hiding this comment.
General Swift style comment, should't we use print("pushRegistry:didReceiveIncomingPushWithPayload:forType:completion:") instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pushRegistry:didReceiveIncomingPushWithPayload:forType:withCompletionHandler:is available on iOS 11 and above. The originalpushRegistry:didReceiveIncomingPushWithPayload:forType:will soon be deprecated by Apple.The
pushRegistry:didReceiveIncomingPushWithPayload:forType:withCompletionHandler:method will be called if both the methods exist.Note: calling the
TwilioVoice.handleNotification()method is guaranteed to get at least one of theTVONotificationDelegatecallback immediately, so it is safe to call the completion handler right after callingTwilioVoice.handleNotification().