Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: dynamic reload services config #29

Closed
mstrYoda opened this issue Nov 11, 2020 · 3 comments
Closed

feature request: dynamic reload services config #29

mstrYoda opened this issue Nov 11, 2020 · 3 comments
Assignees
@TwiN
Labels
feature New feature or request

Comments

@mstrYoda
Copy link

It would be nice to reload services cfg. This enable us to dynamically create config from another source (like fetching services from consul and generating service config) and reload it via http api or some interval.
@Exagone313
Copy link
Contributor

I think the right implementation would be with inotify (if available on the filesystem). Also, it needs to make sure that the new config doesn't have an error and keep previous config if it failed checks.

@TwiN TwiN mentioned this issue Mar 5, 2021
Closed
@TwiN TwiN mentioned this issue May 16, 2021
Closed
TwiN added a commit that referenced this issue May 19, 2021
@TwiN
#29: Automatically reload on configuration file update
db23bd9
@TwiN TwiN added the feature New feature or request label May 19, 2021
@TwiN TwiN self-assigned this May 19, 2021
TwiN added a commit that referenced this issue May 19, 2021
@TwiN
Merge pull request #115 from TwinProduction/reload-on-update
18420c2 
#29: Automatically reload on configuration file update
@TwiN TwiN closed this as completed May 20, 2021
@TwiN
Copy link
Owner

TwiN commented May 20, 2021

@mstrYoda If you can, let me know if it works well for you.

@TwiN
Copy link
Owner

TwiN commented May 28, 2021

Released in v2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TwiN TwiN

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Exagone313 @mstrYoda @TwiN