Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICMP checks show connected on a host that is down #72

Closed
tertius opened this issue Jan 12, 2021 · 4 comments
Closed

ICMP checks show connected on a host that is down #72

tertius opened this issue Jan 12, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@tertius
Copy link

tertius commented Jan 12, 2021

I'm getting a check on connected for an ICMP but 0ms response time on a host that is down right now. Trying a manual ping from the docker host shows the same.

I've changed the condition to "[RESPONSE_TIME] > 0"

@TwiN
Copy link
Owner

TwiN commented Jan 13, 2021

@tertius What version of Gatus are you using?

@TwiN TwiN added the bug Something isn't working label Jan 13, 2021
@TwiN TwiN self-assigned this Jan 13, 2021
@TwiN TwiN closed this as completed in aec867a Jan 13, 2021
@TwiN
Copy link
Owner

TwiN commented Jan 13, 2021

@tertius Thanks for reporting this, I was able to reproduce the issue.

I've pushed the fix to latest; if you could test it on your end to to make sure I didn't miss something, it'd be very appreciated.

@tertius
Copy link
Author

tertius commented Jan 13, 2021

Success, "[CONNECTED] == true" now works for a host that is down. It does show 5000ms, I'm assuming that's the timeout.

@TwiN
Copy link
Owner

TwiN commented Jan 13, 2021

@tertius That's correct.

Once again, thank you for creating an issue about this bug.

I've released this fix in v1.11.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants