Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CSL paths configurable #42

Closed
3 tasks
TwinFan opened this issue Dec 2, 2018 · 4 comments
Closed
3 tasks

Make CSL paths configurable #42

TwinFan opened this issue Dec 2, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@TwinFan
Copy link
Owner

TwinFan commented Dec 2, 2018

Current Situation / Problem
Currently, LiveTraffic looks into the hard-coded path plugins/XSquawkBox/Resources/CSL to find CSL packages. If XSB is installed elsewhere that will fail.
Checking X-IvAp paths is not even implemented yet.

Suggested Solution
Walk all plugins, search for "Resources/CSL" and just take that.
Make multiple calls to XPMPLoadCSLPackage to load additional CSL directories if there is more than one.

Benefits
Independence if individual user's setup.

** Still to do **

  • Settings UI tab with 5 or so edit fields for the paths, and checkboxes for enable/disable
  • ...and maybe a 'Load' button to load a package on demand
  • LTMainInit: Ability to startup and show the settings UI even if CSL init failed
@TwinFan TwinFan added the enhancement New feature or request label Dec 2, 2018
@TwinFan TwinFan added this to the Public Beta v0.9 milestone Dec 2, 2018
@TwinFan TwinFan self-assigned this Dec 2, 2018
@172MC
Copy link

172MC commented Dec 6, 2018

"Make multiple calls to XPMPLoadCSLPackage to load additional CSL directories if there is more than one."

What if they overlap, possibly with conflicts (same ICAO, different models/liveries)

@TwinFan
Copy link
Owner Author

TwinFan commented Dec 6, 2018

I would test that and see what the multiplayer library makes of it. Anyway...there are more issues than that. From your logs, e.g., I read that CSL models are also installed in folder not called "Resources/CSL". I would miss them.

So I am unsure how to allow for a very simple install also for beginners on the one hand, while on the others allow power users like you to fine-tune settings.

Just an idea I had: LT writes out the directories found into the LiveTraffic.prf. A power user can edit that file and specify exactly which directories to consider and which not. And the beginner would just ignore all that and LT would find something somewhere...

And maybe I just make things too complicated and should simply demand a CSL package in my directory like all other plugins do...it's just 3.5 GB in the end :)

@172MC
Copy link

172MC commented Dec 6, 2018

"And maybe I just make things too complicated and should simply demand a CSL package in my directory like all other plugins do...it's just 3.5 GB in the end :)" Yes, disk space is very inexpensive - support of clueless users is very expensive ;-)

@TwinFan
Copy link
Owner Author

TwinFan commented Dec 7, 2018

Yea...I gonna roll back that complexity. The only thing I gonna offer is to configure one (maybe five) paths to CSL directories. And for installation and startup purposes LiveTraffic will only check in its own Resources/CSL. Full stop.

TwinFan added a commit that referenced this issue Dec 8, 2018
@TwinFan TwinFan changed the title Find XSB (and XIVAP?) folder location by querying plugin info instead of hard-coded paths Make CSL paths configurable Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants