-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENV naming for multiple servers #72
Comments
Sure, I agree. I prefer We should probably include the port number in the list of servers, and use make use of I think this commit was our first used of |
I need this for https://github.com/twingly/imse/pull/56. GitHub Actions assign ports randomly to services: https://github.com/actions/example-services/blob/dfd84e0637dda63c0359a07a7161fbfd2a6da738/.github/workflows/postgres-service.yml#L52-L54 |
Oh, we have this: https://github.com/twingly/twingly-amqp#customize-options. I will try it. |
Seems to work |
Currently we're using the following scheme for multiple servers, a new variable per server:
RABBITMQ_01_HOST
RABBITMQ_02_HOST
But for a lot of other servers we use:
MEMCACHIER_SERVERS
KESTREL_SERVERS
So the question is, what do we prefer?
I'm leaning towards using
_SERVERS
or_URLS
with a comma-separated list, that seems to be a general consensus among other gems.I think using fewer variables could be positive during maintenance, as in it's easier to change a variable than make sure it's removed (Consul KV, Heroku config etc).
The text was updated successfully, but these errors were encountered: