Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #1

Closed
jage opened this issue Oct 30, 2013 · 5 comments
Closed

Add tests #1

jage opened this issue Oct 30, 2013 · 5 comments
Assignees
@jage
Labels
bug

Comments

@jage
Copy link
Contributor

jage commented Oct 30, 2013

You never now what will happen without tests...

5f75zun
@ghost ghost assigned jage Oct 30, 2013
@jage
Copy link
Contributor Author

jage commented Feb 17, 2014

This URL should be tested, it causes exceptions.

http://www.iwaseki.co.jp/cgi/yybbs/yybbs.cgi/%DEuropean]buy

@dentarg
Copy link
Collaborator

dentarg commented Feb 17, 2014

This feels important.

@walro
Copy link
Contributor

walro commented Feb 17, 2014

Yes it does.

Not really related to tests, but to the exception, and issue #2, perhaps Addressable could solve both problems?

[4] pry(main)> Addressable::URI.parse('http://www.iwaseki.co.jp/cgi/yybbs/yybbs.cgi/%DEuropean]buy')
=> #<Addressable::URI:0x3fd29d98245c URI:http://www.iwaseki.co.jp/cgi/yybbs/yybbs.cgi/%DEuropean]buy>

@dentarg
Copy link
Collaborator

dentarg commented Feb 17, 2014

I think so.

Offending line: https://github.com/twingly/twingly-url-normalizer/blob/c3e358151065034fb3068782371069e305988b4e/lib/twingly-url-normalizer.rb#L14

@jage
Copy link
Contributor Author

jage commented Feb 23, 2014

Fixed with #3

@jage jage closed this as completed Feb 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jage jage

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jage @dentarg @walro