Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize URL with multiple consecutive dots #125

Closed
jage opened this issue May 21, 2018 · 2 comments · Fixed by #159
Closed

Normalize URL with multiple consecutive dots #125

jage opened this issue May 21, 2018 · 2 comments · Fixed by #159

Comments

@jage
Copy link
Contributor

jage commented May 21, 2018

From #25 (comment)

Instead of:

irb(main):003:0> Twingly::URL.parse("www..hej..se").to_s
=> "http://www..hej..se"
irb(main):004:0> Twingly::URL.parse("www..hej..se").normalized.to_s
=> "http://www..hej..se/"

It would do this:

irb(main):003:0> Twingly::URL.parse("www..hej..se").to_s
=> "http://www..hej..se"
irb(main):004:0> Twingly::URL.parse("www..hej..se").normalized.to_s
=> "http://www.hej.se/"

We might want to change the behaviour in the .NET-normalization as well: #25 (comment)

@dentarg
Copy link
Collaborator

dentarg commented May 21, 2018

Answered in #25 that I don't think these URLs should be valid. If that stands, this issue can be closed without action.

@dentarg
Copy link
Collaborator

dentarg commented Oct 8, 2022

4+ years later I got what I wanted 😄 with #158 these URLs are now considered invalid. This issue can be closed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants