Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for URL: feedville.com,2007-06-19:/blends/16171 #7

Closed
dentarg opened this issue Mar 10, 2014 · 0 comments
Closed

Add test for URL: feedville.com,2007-06-19:/blends/16171 #7

dentarg opened this issue Mar 10, 2014 · 0 comments

Comments

@dentarg
Copy link
Collaborator

dentarg commented Mar 10, 2014

From https://app.getsentry.com/twingly-1/staging-zambezi/group/16231292/ (not sure that that link will work forever, we only have events from the last 30 days at Sentry IIRC)

Addressable::URI::InvalidURIError: Cannot assemble URI string with ambiguous path: 'feedville.com,2007-06-19:/blends/16171'

The raw stacktrace:

Stacktrace (most recent call first):

  addressable/uri.rb:2167:in `to_s'
    raise InvalidURIError,
  /home/deploy/twingly-staging-zambezi/releases/20140305193534/lib/converter.rb:93:in `remove_scheme_from_url'
    uri.to_s
  /home/deploy/twingly-staging-zambezi/releases/20140305193534/lib/converter.rb:81:in `id_for_blog'
    blog_url_without_scheme = remove_scheme_from_url(blog_url)
  /home/deploy/twingly-staging-zambezi/releases/20140305193534/lib/replicator.rb:23:in `replicate_blog'
    blog_id = Converter.id_for_blog(mysql_row[:WebsiteUrl])
  /home/deploy/twingly-staging-zambezi/releases/20140305193534/lib/replicator.rb:15:in `replicate'
    replicate_blog(action, mysql_row)
  zambezi.rb:26:in `block (2 levels) in <main>'
    replicator.replicate(document[:action], document[:type], document[:mysql_row])
  /home/deploy/twingly-staging-zambezi/releases/20140305193534/lib/binlog/message.rb:12:in `call'
    block.call(document)
  /home/deploy/twingly-staging-zambezi/releases/20140305193534/lib/binlog/message.rb:12:in `block in handle_payload'
    block.call(document)
  /home/deploy/twingly-staging-zambezi/releases/20140305193534/lib/binlog/message.rb:10:in `each'
    messages.each do |message|
  /home/deploy/twingly-staging-zambezi/releases/20140305193534/lib/binlog/message.rb:10:in `handle_payload'
    messages.each do |message|
  /home/deploy/twingly-staging-zambezi/releases/20140305193534/lib/binlog/queue.rb:93:in `block in subscribe'
    success = Message.handle_payload(payload, &block)
  bunny/consumer.rb:54:in `call'
    @on_delivery.call(*args) if @on_delivery
  bunny/consumer.rb:54:in `call'
    @on_delivery.call(*args) if @on_delivery
  bunny/channel.rb:1642:in `block in handle_frameset'
    consumer.call(DeliveryInfo.new(basic_deliver, consumer, self), MessageProperties.new(properties), content)
  bunny/consumer_work_pool.rb:84:in `call'
    callable.call
  bunny/consumer_work_pool.rb:84:in `block (2 levels) in run_loop'
    callable.call
  bunny/consumer_work_pool.rb:80:in `loop'
    loop do
  bunny/consumer_work_pool.rb:80:in `block in run_loop'
    loop do
  bunny/consumer_work_pool.rb:79:in `catch'
    catch(:terminate) do
  bunny/consumer_work_pool.rb:79:in `run_loop'
    catch(:terminate) do

I know that we're not using Addressable anymore (https://github.com/twingly/zambezi/pull/84), but I want to have a discussion about how we should handle (malformed) URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant