Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastImage low quality #14

Open
egarim opened this issue Aug 3, 2015 · 6 comments
Open

FastImage low quality #14

egarim opened this issue Aug 3, 2015 · 6 comments

Comments

@egarim
Copy link

egarim commented Aug 3, 2015

Hi
Is there a way to improve the quality of the images on the FASTIMAGE component? FastImage works really fast but the quality of the image is very low in comparison with xamarin ImageView.

here are to sample images, take a look to the first image (the image on top)
this is xamarin imageview

http://content.screencast.com/users/egarim/folders/Jing/media/72483f38-f30e-4085-a94f-0ecae605d627/XamarinImageView.png

this is fastimage
http://content.screencast.com/users/egarim/folders/Jing/media/f829c308-f322-40c3-9f2e-d4def531e604/FastImage.png

@georgejecook
Copy link
Collaborator

Absolutely,

I will expose a property for the android side - iOS side works fine. I’ll get that done this week.

g.

On Aug 3, 2015, at 2:01 PM, egarim notifications@github.com wrote:

Hi
Is there a way to improve the quality of the images on the FASTIMAGE component? FastImage works really fast but the quality of the image is very low in comparison with xamarin ImageView.

here are to sample images, take a look to the first image (the image on top)
this is xamarin imageview

http://content.screencast.com/users/egarim/folders/Jing/media/72483f38-f30e-4085-a94f-0ecae605d627/XamarinImageView.png http://content.screencast.com/users/egarim/folders/Jing/media/72483f38-f30e-4085-a94f-0ecae605d627/XamarinImageView.png
this is fastimage
http://content.screencast.com/users/egarim/folders/Jing/media/f829c308-f322-40c3-9f2e-d4def531e604/FastImage.png http://content.screencast.com/users/egarim/folders/Jing/media/f829c308-f322-40c3-9f2e-d4def531e604/FastImage.png

Reply to this email directly or view it on GitHub #14.

@egarim
Copy link
Author

egarim commented Aug 3, 2015

Thanks George

@georgejecook
Copy link
Collaborator

For now though, you can change the quality in 👍

the ImageLoaderCache.cs file..

change line 19, the number 64, bring that up to the min/width height of the images you'll display.. e.g.

            _onlyLoader = new ImageLoader (Android.App.Application.Context, 320, 40);

that will have a massive effect on quality.

I won't have time to improve this on a per use basis just yet; but will in future.

@egarim
Copy link
Author

egarim commented Aug 12, 2015

Great George ill take a look

On Tuesday, August 11, 2015, George Cook notifications@github.com wrote:

For now though, you can change the quality in [image: 👍]

the ImageLoaderCache.cs file..

change line 19, the number 64, bring that up to the min/width height of
the images you'll display.. e.g.

        _onlyLoader = new ImageLoader (Android.App.Application.Context, 320, 40);

that will have a massive effect on quality.

I won't have time to improve this on a per use basis just yet; but will in
future.


Reply to this email directly or view it on GitHub
#14 (comment)
.

Regards
Jose Manuel Ojeda

Skype:Jose.Manuel.Ojeda
GoogleTalk:joche.ojeda@bitframeworks.com
Cellphone: 503 79235612
QQ:2492739188

@JoshuaNovak919
Copy link

@georgejecook How can we make this work if we have lists with different size images? I have some pages that have one small icon and some pages that have images that take up the entire width.

@georgejecook
Copy link
Collaborator

Hmmm. yes - that would be an issue. I've been very honest about this class just wrapping other people's good work. I've never had a need for the use case you have on android (which has a less flexible implementation than iOS) - that uses : https://github.com/jamesmontemagno/monodroidtoolkit

I suggest you ask James his opinion, and then see if you can do a pull request here to fix it. I won't be thinking about this actively until I have a pressing need, so your own initiative is going to be required for a speedy resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants