Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Invalid/Removed Textures, Fonts, Audio, etc. #34

Closed
Twintop opened this issue Oct 4, 2020 · 4 comments
Closed

Detect Invalid/Removed Textures, Fonts, Audio, etc. #34

Twintop opened this issue Oct 4, 2020 · 4 comments
Assignees
Labels
bug Something isn't working Core Core Module / impacts all class/spec modules enhancement New feature or request

Comments

@Twintop
Copy link
Owner

Twintop commented Oct 4, 2020

Because TIB uses LibSharedMedia, a user can choose a font/texture/audio file to use in the bar that is provided by another addon. If this other addon is removed, the resource is also removed with it. When this happens, the bar will stop functioning in some way -- text not displayed, blank textures, no audio, etc.

Need to add sanity checks around these resources so that if a resource is not available it gracefully changes to a different resource. Also possibly prompt the user that something happened and why.

@Twintop Twintop added bug Something isn't working enhancement New feature or request labels Oct 4, 2020
@Twintop Twintop self-assigned this Oct 4, 2020
@Twintop Twintop added Core Core Module / impacts all class/spec modules low priority This issue is of low priority and may not be completed soon labels Oct 22, 2020
@Twintop Twintop added this to In progress in Twintop's Resource Bar Nov 15, 2020
@Twintop Twintop moved this from In progress to To do in Twintop's Resource Bar Nov 15, 2020
@Twintop Twintop removed the low priority This issue is of low priority and may not be completed soon label Apr 18, 2021
@Twintop
Copy link
Owner Author

Twintop commented Apr 18, 2021

Now that there is an easy way to import/export, this is no longer "low priority". Need to address this to prevent breakage between different LibSharedMedia values.

@Twintop
Copy link
Owner Author

Twintop commented Jun 14, 2021

Had the first reported occurrence of this (via jaerv, on behalf of one of Viklund's subscribers using the import string). Need to do this Soon (no TM).

@Twintop
Copy link
Owner Author

Twintop commented Jun 29, 2021

Another report of this (Tf in Discord), this time with font not being valid and causing no bar text to show up. This was via importing a configuration.

Twintop added a commit that referenced this issue Jul 17, 2021
Twintop added a commit that referenced this issue Jul 17, 2021
@Twintop Twintop closed this as completed Jul 17, 2021
Twintop's Resource Bar automation moved this from To do to Complete but Unreleased Jul 17, 2021
@Twintop Twintop moved this from Complete but Unreleased to Closed in Twintop's Resource Bar Jul 19, 2021
@Twintop Twintop reopened this Jul 21, 2021
Twintop's Resource Bar automation moved this from Closed to In progress Jul 21, 2021
@Twintop
Copy link
Owner Author

Twintop commented Jul 21, 2021

Due to addons loading in different orders, there can be false negative matches on textures/fonts/audio seemingly missing but are actually there (just not loaded yet). Need to change where and when this sanity check is applied.

Twintop's Resource Bar automation moved this from In progress to Complete but Unreleased Jul 22, 2021
@Twintop Twintop moved this from Complete but Unreleased to Closed in Twintop's Resource Bar Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core Core Module / impacts all class/spec modules enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant