Skip to content
This repository has been archived by the owner on Mar 30, 2023. It is now read-only.

Limits >= 20 doesn't work, Tweets option doesn't exist #47

Closed
ghost opened this issue Mar 20, 2018 · 2 comments
Closed

Limits >= 20 doesn't work, Tweets option doesn't exist #47

ghost opened this issue Mar 20, 2018 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Mar 20, 2018

Initial Check

Make sure you've checked the following.

  • [] Python version is 3.5 or higher. True
  • [] Using the latest version of Tweep. True

Command

python tweep.py -u {account} --limit 20

Description of Issue

For account = "binance":
Only 5 latest tweets get parsed and one tweet from 2017 from person @bi_15174872228
image

For account = "vergecurrency":
If --limit < 20 tweets get parsed infinitely(all of them)
If --limit >= 20 exactly 20 tweets get parsed no matter the --limit value

OS Details

Windows 8.1 64

UPD
Just noticed that tweets in line 180 doesn't exist therefore --tweets doesn't work

@haccer
Copy link
Member

haccer commented Mar 21, 2018

Thank you for your input.

Binance

Tweep is fine, Twitter is not:

Not much I can really do there.

Limits

I'll address that issue tomorrow, likely caused by rewrite or pull request.

Tweets

Fixed. Thanks for catching that!

@haccer haccer changed the title Parsing wrong person, not parsing all tweets, ignoring --limit Limits >= 20 doesn't work, Tweets option doesn't exist Mar 21, 2018
@haccer haccer added the bug label Mar 21, 2018
@haccer
Copy link
Member

haccer commented Mar 29, 2018

Sorry I just got to this now, bug was fixed in this commit due to the conditional being less than or equal to, which was corrected to greater than or equal to.

@haccer haccer closed this as completed Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

1 participant