Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditional dep on typing breaks pip #341

Closed
hynek opened this issue May 5, 2020 · 2 comments
Closed

Unconditional dep on typing breaks pip #341

hynek opened this issue May 5, 2020 · 2 comments
Assignees
Labels

Comments

@hynek
Copy link
Member

hynek commented May 5, 2020

There's been a dependency guard on typing for a while now but it hasn't been released yet and it breaks pip now. A new release should be good enough?

pip install -e .
Looking in indexes: https://XXX/+simple/
Obtaining file:///Users/hynek/Work/lookup-svc
  Installing build dependencies ... error
  ERROR: Command errored out with exit status 1:
   command: /Users/hynek/.local/venvs/lookup-svc/bin/python /Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip install --ignore-installed --no-user --prefix /private/var/folders/7f/5bq0ctcs4tl_7k2721s0ycy80000gn/T/pip-build-env-uc3v9xz9/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://XXX/+simple/ -- setuptools wheel cython
       cwd: None
  Complete output (44 lines):
  Traceback (most recent call last):
    File "/Users/hynek/.pyenv/versions/3.8.2/lib/python3.8/runpy.py", line 193, in _run_module_as_main
      return _run_code(code, main_globals, None,
    File "/Users/hynek/.pyenv/versions/3.8.2/lib/python3.8/runpy.py", line 86, in _run_code
      exec(code, run_globals)
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/__main__.py", line 26, in <module>
      sys.exit(_main())
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_internal/cli/main.py", line 73, in main
      command = create_command(cmd_name, isolated=("--isolated" in cmd_args))
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_internal/commands/__init__.py", line 104, in create_command
      module = importlib.import_module(module_path)
    File "/Users/hynek/.pyenv/versions/3.8.2/lib/python3.8/importlib/__init__.py", line 127, in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
    File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
    File "<frozen importlib._bootstrap>", line 991, in _find_and_load
    File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
    File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 783, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_internal/commands/install.py", line 24, in <module>
      from pip._internal.cli.req_command import RequirementCommand, with_cleanup
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_internal/cli/req_command.py", line 16, in <module>
      from pip._internal.index.package_finder import PackageFinder
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_internal/index/package_finder.py", line 21, in <module>
      from pip._internal.index.collector import parse_links
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_internal/index/collector.py", line 14, in <module>
      from pip._vendor import html5lib, requests
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_vendor/requests/__init__.py", line 114, in <module>
      from . import utils
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_vendor/requests/utils.py", line 25, in <module>
      from . import certs
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_vendor/requests/certs.py", line 15, in <module>
      from pip._vendor.certifi import where
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_vendor/certifi/__init__.py", line 1, in <module>
      from .core import contents, where
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/pip/_vendor/certifi/core.py", line 12, in <module>
      from importlib.resources import read_text
    File "/Users/hynek/.pyenv/versions/3.8.2/lib/python3.8/importlib/resources.py", line 11, in <module>
      from typing import Iterable, Iterator, Optional, Set, Union   # noqa: F401
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/typing.py", line 1357, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "/Users/hynek/.local/venvs/lookup-svc/lib/python3.8/site-packages/typing.py", line 1005, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'
@wsanchez wsanchez added the bug label May 5, 2020
@wsanchez
Copy link
Member

wsanchez commented May 5, 2020

#353 for a new release.

It's waiting on some PRs (#308, #311) that add type hints, if you wanna have a go at them. :-)

@wsanchez
Copy link
Member

Should be ok now in Klein 20.6.

@wsanchez wsanchez self-assigned this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants