Vendor click_default_group to make us installable again #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #492 Co-authored-by: Heungsub Lee <19982+sublee@users.noreply.github.com>
|
I don't know if we need to make it a whole Policy Thing, but I think it would be nice to submit the pip fix upstream to at least have a PR to point at, in the event that we could ever un-vendor the thing. Is the pip fix hard? I don't know what the pip issue is |
glyph
approved these changes
Aug 4, 2023
|
The technicalities aren't hard, but they seem to have problems to get access: click-contrib/click-default-group#24 But then again, it's less then 200 LoC that haven't changed since 2019 so I think it's fine to leave it as it is. |
|
@hynek FYI yesterday I reached out to the author via email and he repackaged the thing today, in response. So maybe this could be reverted after all... |
|
Yeah, but why should we? Again: it's 200 LoC that never change and it's one dependency and potential problem less. If click ever breaks compat and we need to update, we can reconsider. But it's not like my ego hangs on that, if they get a release out, for all I care revert. |
|
I don't care enough either. Just wanted to document this properly. |
github-actions bot
pushed a commit
to aio-libs/aiohttp
that referenced
this pull request
Oct 24, 2023
Bumps [towncrier](https://github.com/twisted/towncrier) from 23.6.0 to 23.10.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/twisted/towncrier/releases">towncrier's releases</a>.</em></p> <blockquote> <h2>Towncrier 23.10.0</h2> <h1>towncrier 23.10.0 (2023-10-23)</h1> <p>No significant changes since the previous release candidate.</p> <h2>Features</h2> <ul> <li> <p>Python 3.12 is now officially supported. (<code>[#541](twisted/towncrier#541) <https://github.com/twisted/towncrier/issues/541></code>_)</p> </li> <li> <p>Initial support was added for monorepo-style setup. One project with multiple independent news files stored in separate sub-directories, that share the same towncrier config. (<code>[#548](twisted/towncrier#548) <https://github.com/twisted/towncrier/issues/548></code>_)</p> </li> <li> <p>Two newlines are no longer always added between the current release notes and the previous content. The newlines are now defined only inside the template.</p> <p><strong>Important! If you're using a custom template and want to keep the same whitespace between releases, you may have to modify your template.</strong> (<code>[#552](twisted/towncrier#552) <https://github.com/twisted/towncrier/issues/552></code>_)</p> </li> </ul> <h2>Bugfixes</h2> <ul> <li>Towncrier now vendors the click-default-group package that prevented installations on modern Pips. (<code>[#540](twisted/towncrier#540) <https://github.com/twisted/towncrier/issues/540></code>_)</li> </ul> <h2>Improved Documentation</h2> <ul> <li>The markdown docs now use the default markdown template rather than a simpler custom one. (<code>[#545](twisted/towncrier#545) <https://github.com/twisted/towncrier/issues/545></code>_)</li> <li>Cleanup a duplicate backtick in the tutorial. (<code>[#551](twisted/towncrier#551) <https://github.com/twisted/towncrier/issues/551></code>_)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>The support for Python 3.7 has been dropped. (<code>[#521](twisted/towncrier#521) <https://github.com/twisted/towncrier/issues/521></code>_)</li> </ul> <h2>Misc</h2> <ul> <li><code>[#481](twisted/towncrier#481) <https://github.com/twisted/towncrier/issues/481></code><em>, <code>[#520](twisted/towncrier#520) <https://github.com/twisted/towncrier/issues/520></code></em>, <code>[#522](twisted/towncrier#522) <https://github.com/twisted/towncrier/issues/522></code><em>, <code>[#523](twisted/towncrier#523) <https://github.com/twisted/towncrier/issues/523></code></em>, <code>[#529](twisted/towncrier#529) <https://github.com/twisted/towncrier/issues/529></code><em>, <code>[#536](twisted/towncrier#536) <https://github.com/twisted/towncrier/issues/536></code></em></li> </ul> <h2>Towncrier 23.10.0rc1</h2> <h1>towncrier 23.10.0rc1 (2023-10-23)</h1> <h2>Features</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's changelog</a>.</em></p> <blockquote> <h1>towncrier 23.10.0 (2023-10-24)</h1> <p>No significant changes since the previous release candidate.</p> <h2>Features</h2> <ul> <li> <p>Python 3.12 is now officially supported. (<code>[#541](twisted/towncrier#541) <https://github.com/twisted/towncrier/issues/541></code>_)</p> </li> <li> <p>Initial support was added for monorepo-style setup. One project with multiple independent news files stored in separate sub-directories, that share the same towncrier config. (<code>[#548](twisted/towncrier#548) <https://github.com/twisted/towncrier/issues/548></code>_)</p> </li> <li> <p>Two newlines are no longer always added between the current release notes and the previous content. The newlines are now defined only inside the template.</p> <p><strong>Important! If you're using a custom template and want to keep the same whitespace between releases, you may have to modify your template.</strong> (<code>[#552](twisted/towncrier#552) <https://github.com/twisted/towncrier/issues/552></code>_)</p> </li> </ul> <h2>Bugfixes</h2> <ul> <li>Towncrier now vendors the click-default-group package that prevented installations on modern Pips. (<code>[#540](twisted/towncrier#540) <https://github.com/twisted/towncrier/issues/540></code>_)</li> </ul> <h2>Improved Documentation</h2> <ul> <li>The markdown docs now use the default markdown template rather than a simpler custom one. (<code>[#545](twisted/towncrier#545) <https://github.com/twisted/towncrier/issues/545></code>_)</li> <li>Cleanup a duplicate backtick in the tutorial. (<code>[#551](twisted/towncrier#551) <https://github.com/twisted/towncrier/issues/551></code>_)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>The support for Python 3.7 has been dropped. (<code>[#521](twisted/towncrier#521) <https://github.com/twisted/towncrier/issues/521></code>_)</li> </ul> <h2>Misc</h2> <ul> <li><code>[#481](twisted/towncrier#481) <https://github.com/twisted/towncrier/issues/481></code><em>, <code>[#520](twisted/towncrier#520) <https://github.com/twisted/towncrier/issues/520></code></em>, <code>[#522](twisted/towncrier#522) <https://github.com/twisted/towncrier/issues/522></code><em>, <code>[#523](twisted/towncrier#523) <https://github.com/twisted/towncrier/issues/523></code></em>, <code>[#529](twisted/towncrier#529) <https://github.com/twisted/towncrier/issues/529></code><em>, <code>[#536](twisted/towncrier#536) <https://github.com/twisted/towncrier/issues/536></code></em></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twisted/towncrier/commit/347e9440ae8507adfc22f5c993f4496b20d49ec5"><code>347e944</code></a> Update for final release.</li> <li><a href="https://github.com/twisted/towncrier/commit/ee857403c9a09ca7055f93dd8784e84b5cc2bb3a"><code>ee85740</code></a> Do RC1 instead of RC0.</li> <li><a href="https://github.com/twisted/towncrier/commit/0c3b82c9be435e23019b7064a57fbd7210f54300"><code>0c3b82c</code></a> venv/bin/towncrier build --yes</li> <li><a href="https://github.com/twisted/towncrier/commit/610247f8e0e2146cadb9f46937047dc08f923eab"><code>610247f</code></a> Update version.</li> <li><a href="https://github.com/twisted/towncrier/commit/0b023fa95926470482418d4e11f9ae9f0ada7d56"><code>0b023fa</code></a> Config location separate from directory containing news file and fragments (#...</li> <li><a href="https://github.com/twisted/towncrier/commit/3f24b6ef7e0c17f3e559b957526598c287774b70"><code>3f24b6e</code></a> Whitespace between releases can be configured in the template. (<a href="https://redirect.github.com/twisted/towncrier/issues/553">#553</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/7f37ab5daa72f5a761db1bf14cba1e2d3d87422d"><code>7f37ab5</code></a> docs(tutorial): Cleanup duplicate backtick typo (<a href="https://redirect.github.com/twisted/towncrier/issues/551">#551</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/5b732be979642c5b9ab4d22df6fb70ff4bd3ff2f"><code>5b732be</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/twisted/towncrier/issues/549">#549</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/239f84102c374e7395cdc0a50f7b4171cc8c3e83"><code>239f841</code></a> use markdown default template in markdown docs (<a href="https://redirect.github.com/twisted/towncrier/issues/546">#546</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/806bec1248b0ea8b86db21e0ce90b1849d3cd721"><code>806bec1</code></a> Add 3.12 (<a href="https://redirect.github.com/twisted/towncrier/issues/541">#541</a>)</li> <li>Additional commits viewable in <a href="https://github.com/twisted/towncrier/compare/23.6.0...23.10.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
to aio-libs/aiohttp
that referenced
this pull request
Oct 24, 2023
Bumps [towncrier](https://github.com/twisted/towncrier) from 23.6.0 to 23.10.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/twisted/towncrier/releases">towncrier's releases</a>.</em></p> <blockquote> <h2>Towncrier 23.10.0</h2> <h1>towncrier 23.10.0 (2023-10-23)</h1> <p>No significant changes since the previous release candidate.</p> <h2>Features</h2> <ul> <li> <p>Python 3.12 is now officially supported. (<code>[#541](twisted/towncrier#541) <https://github.com/twisted/towncrier/issues/541></code>_)</p> </li> <li> <p>Initial support was added for monorepo-style setup. One project with multiple independent news files stored in separate sub-directories, that share the same towncrier config. (<code>[#548](twisted/towncrier#548) <https://github.com/twisted/towncrier/issues/548></code>_)</p> </li> <li> <p>Two newlines are no longer always added between the current release notes and the previous content. The newlines are now defined only inside the template.</p> <p><strong>Important! If you're using a custom template and want to keep the same whitespace between releases, you may have to modify your template.</strong> (<code>[#552](twisted/towncrier#552) <https://github.com/twisted/towncrier/issues/552></code>_)</p> </li> </ul> <h2>Bugfixes</h2> <ul> <li>Towncrier now vendors the click-default-group package that prevented installations on modern Pips. (<code>[#540](twisted/towncrier#540) <https://github.com/twisted/towncrier/issues/540></code>_)</li> </ul> <h2>Improved Documentation</h2> <ul> <li>The markdown docs now use the default markdown template rather than a simpler custom one. (<code>[#545](twisted/towncrier#545) <https://github.com/twisted/towncrier/issues/545></code>_)</li> <li>Cleanup a duplicate backtick in the tutorial. (<code>[#551](twisted/towncrier#551) <https://github.com/twisted/towncrier/issues/551></code>_)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>The support for Python 3.7 has been dropped. (<code>[#521](twisted/towncrier#521) <https://github.com/twisted/towncrier/issues/521></code>_)</li> </ul> <h2>Misc</h2> <ul> <li><code>[#481](twisted/towncrier#481) <https://github.com/twisted/towncrier/issues/481></code><em>, <code>[#520](twisted/towncrier#520) <https://github.com/twisted/towncrier/issues/520></code></em>, <code>[#522](twisted/towncrier#522) <https://github.com/twisted/towncrier/issues/522></code><em>, <code>[#523](twisted/towncrier#523) <https://github.com/twisted/towncrier/issues/523></code></em>, <code>[#529](twisted/towncrier#529) <https://github.com/twisted/towncrier/issues/529></code><em>, <code>[#536](twisted/towncrier#536) <https://github.com/twisted/towncrier/issues/536></code></em></li> </ul> <h2>Towncrier 23.10.0rc1</h2> <h1>towncrier 23.10.0rc1 (2023-10-23)</h1> <h2>Features</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's changelog</a>.</em></p> <blockquote> <h1>towncrier 23.10.0 (2023-10-24)</h1> <p>No significant changes since the previous release candidate.</p> <h2>Features</h2> <ul> <li> <p>Python 3.12 is now officially supported. (<code>[#541](twisted/towncrier#541) <https://github.com/twisted/towncrier/issues/541></code>_)</p> </li> <li> <p>Initial support was added for monorepo-style setup. One project with multiple independent news files stored in separate sub-directories, that share the same towncrier config. (<code>[#548](twisted/towncrier#548) <https://github.com/twisted/towncrier/issues/548></code>_)</p> </li> <li> <p>Two newlines are no longer always added between the current release notes and the previous content. The newlines are now defined only inside the template.</p> <p><strong>Important! If you're using a custom template and want to keep the same whitespace between releases, you may have to modify your template.</strong> (<code>[#552](twisted/towncrier#552) <https://github.com/twisted/towncrier/issues/552></code>_)</p> </li> </ul> <h2>Bugfixes</h2> <ul> <li>Towncrier now vendors the click-default-group package that prevented installations on modern Pips. (<code>[#540](twisted/towncrier#540) <https://github.com/twisted/towncrier/issues/540></code>_)</li> </ul> <h2>Improved Documentation</h2> <ul> <li>The markdown docs now use the default markdown template rather than a simpler custom one. (<code>[#545](twisted/towncrier#545) <https://github.com/twisted/towncrier/issues/545></code>_)</li> <li>Cleanup a duplicate backtick in the tutorial. (<code>[#551](twisted/towncrier#551) <https://github.com/twisted/towncrier/issues/551></code>_)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>The support for Python 3.7 has been dropped. (<code>[#521](twisted/towncrier#521) <https://github.com/twisted/towncrier/issues/521></code>_)</li> </ul> <h2>Misc</h2> <ul> <li><code>[#481](twisted/towncrier#481) <https://github.com/twisted/towncrier/issues/481></code><em>, <code>[#520](twisted/towncrier#520) <https://github.com/twisted/towncrier/issues/520></code></em>, <code>[#522](twisted/towncrier#522) <https://github.com/twisted/towncrier/issues/522></code><em>, <code>[#523](twisted/towncrier#523) <https://github.com/twisted/towncrier/issues/523></code></em>, <code>[#529](twisted/towncrier#529) <https://github.com/twisted/towncrier/issues/529></code><em>, <code>[#536](twisted/towncrier#536) <https://github.com/twisted/towncrier/issues/536></code></em></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twisted/towncrier/commit/347e9440ae8507adfc22f5c993f4496b20d49ec5"><code>347e944</code></a> Update for final release.</li> <li><a href="https://github.com/twisted/towncrier/commit/ee857403c9a09ca7055f93dd8784e84b5cc2bb3a"><code>ee85740</code></a> Do RC1 instead of RC0.</li> <li><a href="https://github.com/twisted/towncrier/commit/0c3b82c9be435e23019b7064a57fbd7210f54300"><code>0c3b82c</code></a> venv/bin/towncrier build --yes</li> <li><a href="https://github.com/twisted/towncrier/commit/610247f8e0e2146cadb9f46937047dc08f923eab"><code>610247f</code></a> Update version.</li> <li><a href="https://github.com/twisted/towncrier/commit/0b023fa95926470482418d4e11f9ae9f0ada7d56"><code>0b023fa</code></a> Config location separate from directory containing news file and fragments (#...</li> <li><a href="https://github.com/twisted/towncrier/commit/3f24b6ef7e0c17f3e559b957526598c287774b70"><code>3f24b6e</code></a> Whitespace between releases can be configured in the template. (<a href="https://redirect.github.com/twisted/towncrier/issues/553">#553</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/7f37ab5daa72f5a761db1bf14cba1e2d3d87422d"><code>7f37ab5</code></a> docs(tutorial): Cleanup duplicate backtick typo (<a href="https://redirect.github.com/twisted/towncrier/issues/551">#551</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/5b732be979642c5b9ab4d22df6fb70ff4bd3ff2f"><code>5b732be</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/twisted/towncrier/issues/549">#549</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/239f84102c374e7395cdc0a50f7b4171cc8c3e83"><code>239f841</code></a> use markdown default template in markdown docs (<a href="https://redirect.github.com/twisted/towncrier/issues/546">#546</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/806bec1248b0ea8b86db21e0ce90b1849d3cd721"><code>806bec1</code></a> Add 3.12 (<a href="https://redirect.github.com/twisted/towncrier/issues/541">#541</a>)</li> <li>Additional commits viewable in <a href="https://github.com/twisted/towncrier/compare/23.6.0...23.10.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
xiangxli
pushed a commit
to xiangxli/aiohttp
that referenced
this pull request
Dec 4, 2023
Bumps [towncrier](https://github.com/twisted/towncrier) from 23.6.0 to 23.10.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/twisted/towncrier/releases">towncrier's releases</a>.</em></p> <blockquote> <h2>Towncrier 23.10.0</h2> <h1>towncrier 23.10.0 (2023-10-23)</h1> <p>No significant changes since the previous release candidate.</p> <h2>Features</h2> <ul> <li> <p>Python 3.12 is now officially supported. (<code>[aio-libs#541](twisted/towncrier#541) <https://github.com/twisted/towncrier/issues/541></code>_)</p> </li> <li> <p>Initial support was added for monorepo-style setup. One project with multiple independent news files stored in separate sub-directories, that share the same towncrier config. (<code>[aio-libs#548](twisted/towncrier#548) <https://github.com/twisted/towncrier/issues/548></code>_)</p> </li> <li> <p>Two newlines are no longer always added between the current release notes and the previous content. The newlines are now defined only inside the template.</p> <p><strong>Important! If you're using a custom template and want to keep the same whitespace between releases, you may have to modify your template.</strong> (<code>[aio-libs#552](twisted/towncrier#552) <https://github.com/twisted/towncrier/issues/552></code>_)</p> </li> </ul> <h2>Bugfixes</h2> <ul> <li>Towncrier now vendors the click-default-group package that prevented installations on modern Pips. (<code>[aio-libs#540](twisted/towncrier#540) <https://github.com/twisted/towncrier/issues/540></code>_)</li> </ul> <h2>Improved Documentation</h2> <ul> <li>The markdown docs now use the default markdown template rather than a simpler custom one. (<code>[aio-libs#545](twisted/towncrier#545) <https://github.com/twisted/towncrier/issues/545></code>_)</li> <li>Cleanup a duplicate backtick in the tutorial. (<code>[aio-libs#551](twisted/towncrier#551) <https://github.com/twisted/towncrier/issues/551></code>_)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>The support for Python 3.7 has been dropped. (<code>[aio-libs#521](twisted/towncrier#521) <https://github.com/twisted/towncrier/issues/521></code>_)</li> </ul> <h2>Misc</h2> <ul> <li><code>[aio-libs#481](twisted/towncrier#481) <https://github.com/twisted/towncrier/issues/481></code><em>, <code>[aio-libs#520](twisted/towncrier#520) <https://github.com/twisted/towncrier/issues/520></code></em>, <code>[aio-libs#522](twisted/towncrier#522) <https://github.com/twisted/towncrier/issues/522></code><em>, <code>[aio-libs#523](twisted/towncrier#523) <https://github.com/twisted/towncrier/issues/523></code></em>, <code>[aio-libs#529](twisted/towncrier#529) <https://github.com/twisted/towncrier/issues/529></code><em>, <code>[aio-libs#536](twisted/towncrier#536) <https://github.com/twisted/towncrier/issues/536></code></em></li> </ul> <h2>Towncrier 23.10.0rc1</h2> <h1>towncrier 23.10.0rc1 (2023-10-23)</h1> <h2>Features</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's changelog</a>.</em></p> <blockquote> <h1>towncrier 23.10.0 (2023-10-24)</h1> <p>No significant changes since the previous release candidate.</p> <h2>Features</h2> <ul> <li> <p>Python 3.12 is now officially supported. (<code>[aio-libs#541](twisted/towncrier#541) <https://github.com/twisted/towncrier/issues/541></code>_)</p> </li> <li> <p>Initial support was added for monorepo-style setup. One project with multiple independent news files stored in separate sub-directories, that share the same towncrier config. (<code>[aio-libs#548](twisted/towncrier#548) <https://github.com/twisted/towncrier/issues/548></code>_)</p> </li> <li> <p>Two newlines are no longer always added between the current release notes and the previous content. The newlines are now defined only inside the template.</p> <p><strong>Important! If you're using a custom template and want to keep the same whitespace between releases, you may have to modify your template.</strong> (<code>[aio-libs#552](twisted/towncrier#552) <https://github.com/twisted/towncrier/issues/552></code>_)</p> </li> </ul> <h2>Bugfixes</h2> <ul> <li>Towncrier now vendors the click-default-group package that prevented installations on modern Pips. (<code>[aio-libs#540](twisted/towncrier#540) <https://github.com/twisted/towncrier/issues/540></code>_)</li> </ul> <h2>Improved Documentation</h2> <ul> <li>The markdown docs now use the default markdown template rather than a simpler custom one. (<code>[aio-libs#545](twisted/towncrier#545) <https://github.com/twisted/towncrier/issues/545></code>_)</li> <li>Cleanup a duplicate backtick in the tutorial. (<code>[aio-libs#551](twisted/towncrier#551) <https://github.com/twisted/towncrier/issues/551></code>_)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>The support for Python 3.7 has been dropped. (<code>[aio-libs#521](twisted/towncrier#521) <https://github.com/twisted/towncrier/issues/521></code>_)</li> </ul> <h2>Misc</h2> <ul> <li><code>[aio-libs#481](twisted/towncrier#481) <https://github.com/twisted/towncrier/issues/481></code><em>, <code>[aio-libs#520](twisted/towncrier#520) <https://github.com/twisted/towncrier/issues/520></code></em>, <code>[aio-libs#522](twisted/towncrier#522) <https://github.com/twisted/towncrier/issues/522></code><em>, <code>[aio-libs#523](twisted/towncrier#523) <https://github.com/twisted/towncrier/issues/523></code></em>, <code>[aio-libs#529](twisted/towncrier#529) <https://github.com/twisted/towncrier/issues/529></code><em>, <code>[aio-libs#536](twisted/towncrier#536) <https://github.com/twisted/towncrier/issues/536></code></em></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twisted/towncrier/commit/347e9440ae8507adfc22f5c993f4496b20d49ec5"><code>347e944</code></a> Update for final release.</li> <li><a href="https://github.com/twisted/towncrier/commit/ee857403c9a09ca7055f93dd8784e84b5cc2bb3a"><code>ee85740</code></a> Do RC1 instead of RC0.</li> <li><a href="https://github.com/twisted/towncrier/commit/0c3b82c9be435e23019b7064a57fbd7210f54300"><code>0c3b82c</code></a> venv/bin/towncrier build --yes</li> <li><a href="https://github.com/twisted/towncrier/commit/610247f8e0e2146cadb9f46937047dc08f923eab"><code>610247f</code></a> Update version.</li> <li><a href="https://github.com/twisted/towncrier/commit/0b023fa95926470482418d4e11f9ae9f0ada7d56"><code>0b023fa</code></a> Config location separate from directory containing news file and fragments (#...</li> <li><a href="https://github.com/twisted/towncrier/commit/3f24b6ef7e0c17f3e559b957526598c287774b70"><code>3f24b6e</code></a> Whitespace between releases can be configured in the template. (<a href="https://redirect.github.com/twisted/towncrier/issues/553">#553</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/7f37ab5daa72f5a761db1bf14cba1e2d3d87422d"><code>7f37ab5</code></a> docs(tutorial): Cleanup duplicate backtick typo (<a href="https://redirect.github.com/twisted/towncrier/issues/551">#551</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/5b732be979642c5b9ab4d22df6fb70ff4bd3ff2f"><code>5b732be</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/twisted/towncrier/issues/549">#549</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/239f84102c374e7395cdc0a50f7b4171cc8c3e83"><code>239f841</code></a> use markdown default template in markdown docs (<a href="https://redirect.github.com/twisted/towncrier/issues/546">#546</a>)</li> <li><a href="https://github.com/twisted/towncrier/commit/806bec1248b0ea8b86db21e0ce90b1849d3cd721"><code>806bec1</code></a> Add 3.12 (<a href="https://redirect.github.com/twisted/towncrier/issues/541">#541</a>)</li> <li>Additional commits viewable in <a href="https://github.com/twisted/towncrier/compare/23.6.0...23.10.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
pmisik
added a commit
to pmisik/buildbot
that referenced
this pull request
Dec 20, 2023
…ove dependancy on click_default_group package twisted/towncrier#492 twisted/towncrier#540
pmisik
added a commit
to pmisik/buildbot
that referenced
this pull request
Dec 22, 2023
…ove dependancy on click_default_group package twisted/towncrier#492 twisted/towncrier#540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492
IANAL, but this should be OK since it keeps the copyright around.
I've blocked it from type checks and coverage because I'm not gonna start writing tests and type annotations that didn't exist before. If someone at some point wants to fix that (and maybe remove unneeded code); be my guest. :)