Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treq or Treq? #181

Closed
markrwilliams opened this issue Mar 28, 2017 · 3 comments
Closed

treq or Treq? #181

markrwilliams opened this issue Mar 28, 2017 · 3 comments

Comments

@markrwilliams
Copy link
Member

setup.py names the distribution treq but the version names the package Treq.

This isn't a huge deal because incremental's Version does case-insensitive name comparisons. Consistency is good, though.

I'm pretty sure it should be treq because that's what its name has always been.

@dmurvihill
Copy link

incremental does case-insensitive name comparisons, but pip and PyPi do not. This inconsistency has caused difficulty for me before.

I would prefer to change the package name.

  • eliminates some annoying edge cases
  • consistent with the package name 'Twisted'

Not sure what would be the path to making this change non-destructively -- maintain two packages (deprecated 'treq' and recommended 'Treq') for a while and then make version 17 the last release of 'treq'?

@glyph
Copy link
Member

glyph commented Apr 10, 2017

Wasn't this resolved in the run-up to 17.3?

@twm
Copy link
Contributor

twm commented May 30, 2017

Yes, this has been resolved: both setup.py and _version.py say "treq".

@twm twm closed this as completed May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants