Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update all the proto_helpers references, with fallbacks #253

Merged
merged 1 commit into from
Aug 4, 2019
Merged

update all the proto_helpers references, with fallbacks #253

merged 1 commit into from
Aug 4, 2019

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Aug 2, 2019

Fixes: #252

twm
twm approved these changes Aug 4, 2019
View reviewed changes
Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

I don't know what's up with Coveralls, but I verified that there is coverage of the new lines in the py37-twisted_trunk-pyopenssl_trunk env.

@twm twm merged commit 26651ab into master Aug 4, 2019
@twm twm deleted the 252-proto_helpers branch August 4, 2019 22:33
@twm twm mentioned this pull request Aug 11, 2019
Merged
twm added a commit to twm/treq that referenced this pull request Mar 15, 2020
@twm
Backfill changelog for twisted#253
342e6d9
bmwiedemann added a commit to bmwiedemann/openSUSE that referenced this pull request Mar 25, 2020
@bmwiedemann
Update python-treq to rev 5 via SR 788271
f0d7c86 
https://build.opensuse.org/request/show/788271
by user scarabeus_iv + dimstar_suse
- version update to 20.3.0
  - Python 3.7 support. (`#228 <https://github.com/twisted/treq/issues/228>`__)
  - `treq.testing.RequestTraversalAgent` now passes its memory reactor to the `twisted.web.server.Site` it creates, preventing the ``Site`` from polluting the global reactor. (`#225 <https://github.com/twisted/treq/issues/225>`__)
  - `treq.testing` no longer generates deprecation warnings about ``twisted.test.proto_helpers.MemoryReactor``. (`#253 <https://github.com/twisted/treq/issues/253>`__)
  - The ``download_file.py`` example has been updated to do a streaming download with *unbuffered=True*. (`#233 <https://github.com/twisted/treq/issues/233>`__)
  - The *agent* parameter to `treq.request()` has been documented. (`#235 <https://github.com/twisted/treq/issues/235>`__)
  - The typ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twm twm twm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

twisted.test.proto_helpers is deprecated in trunk@HEAD
4 participants
@exarkun @twm @graingert @glyph