Deprecate passing invalid keyword arguments #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put all the icky global state in one place.
twm
force-pushed
the
287-invalid-kwargs
branch
from
1f7ace1
to
14e07d7
Compare
3 tasks
ryban
approved these changes
Oct 9, 2020
| if json is not _NOTHING: | ||
| return ( | ||
| self._data_to_body_producer( | ||
| json_dumps(json, separators=(u',', u':')).encode('utf-8'), |
There was a problem hiding this comment.
The u strings shouldn't be needed right? They would only make the output unicode in python2, but the encode makes it bytes anyways.
When will treq drop python 2 anyways?
There was a problem hiding this comment.
I suppose the u isn't necessary, but I will leave it as-is since I was only moving it.
Treq will probably drop Python 2 once the Twisted release is out. I want to kick out a release with these deprecations first, though.
|
Thanks for the review @ryban! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step described in #287.