Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distrial - write test.log always in utf-8. #10157

Closed
twisted-trac opened this issue Mar 28, 2021 · 2 comments
Closed

distrial - write test.log always in utf-8. #10157

twisted-trac opened this issue Mar 28, 2021 · 2 comments

Comments

@twisted-trac
Copy link

adiroiban's avatar @adiroiban reported
Trac ID trac#10157
Type defect
Created 2021-03-28 02:07:45Z

Right now the test.log is written in default encoding.

The default encoding can be cp1252 on windows.

The sub-process sends logs data as unicode via AMP and with cp1252 encoding things break.

Searchable metadata
trac-id__10157 10157
type__defect defect
reporter__adiroiban adiroiban
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__trial trial
keywords__review review
time__1616897265553036 1616897265553036
changetime__1621026308344329 1621026308344329
version__None None
owner__Adi_Roiban__adiroiban_____ Adi Roiban <adiroiban@...>

@twisted-trac
Copy link
Author

adiroiban's avatar @adiroiban commented

PR at #1572

@twisted-trac
Copy link
Author

adiroiban's avatar @adiroiban set owner to @adiroiban
@adiroiban set status to closed

In changeset 927e52f

#!CommitTicketReference repository="" revision="927e52fa0067a6371bdcb8d2ffe7b08fd9fe1b09"
Merge pull request #1572 from twisted/10157-distrial-utf8-log-file

Merge pull request #123 from twisted/4356-branch-name-with-trac-id

Author: adiroiban
Reviewer: wiml
Fixes: ticket:10157

Always write distrial log file in UTF-8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants