Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests after py3.8 and 3.9 updates #10230

Closed
twisted-trac opened this issue Jul 15, 2021 · 3 comments
Closed

Fix tests after py3.8 and 3.9 updates #10230

twisted-trac opened this issue Jul 15, 2021 · 3 comments

Comments

@twisted-trac
Copy link

adiroiban's avatar @adiroiban reported
Trac ID trac#10230
Type release blocker: regression
Created 2021-07-15 10:12:44Z

This is the PR for fixing the tests.

https://bugs.python.org/issue44070

Observed on

3.9.6 - https://github.com/twisted/twisted/pull/1614/checks?check_run_id=3075151553#step:9:17972

3.8.11 - https://github.com/twisted/twisted/pull/1614/checks?check_run_id=3075151499#step:9:17972

If it takes more than 1 day to fix this, I plan to create a separate ticket with the scope of just skipping the failing tests and making trunk green again

and depending on the severity, update the release notes with information that latest 3.8 and 3.9 python versions are not supported.

Searchable metadata
trac-id__10230 10230
type__release_blocker__regression release blocker: regression
reporter__adiroiban adiroiban
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1626343964585254 1626343964585254
changetime__1626937683309895 1626937683309895
version__None None
owner__None None
cc__graingert
@twisted-trac
Copy link
Author

graingert's avatar @graingert commented

#1628

@twisted-trac
Copy link
Author

adiroiban's avatar @adiroiban commented

This was fixed in #1628

@twisted-trac
Copy link
Author

glyph's avatar @glyph set status to closed

Please try to keep ticket state up to date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant