Run Black

[twisted-trac]

	@hawkowl reported
Trac ID	trac#9512
Type	task
Created	2018-08-25 03:00:53Z

See: #9498

Searchable metadata

trac-id__9512 9512
type__task task
reporter__hawkowl hawkowl
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__review review
time__1535166053398426 1535166053398426
changetime__1599973580164755 1599973580164755
version__None None
owner__Tom_Most__twm_____ Tom Most <twm@...>

[twisted-trac]

	@glyph set owner to @hawkowl

The thing that's in review is probably this: #1049

But right now that's nothing but a mess of conflicts and can't be merged, more or less as one would expect.

We really need a tool that we can run against arbitrary other branches so that this won't be so disruptive to everyone working on changes in progress.

Once we have that with some good documentation (does Black already have such a thing?) we should probably have the actual run-Black-on-everything PR skip the normal process.

[twisted-trac]

	@hawkowl set owner to @glyph

[twisted-trac]

	@hawkowl commented

Put the PR back up for review.

Since we dropped 2.7 compat and we're starting to sprinkle in type annotations, I think that black would be extra useful to help reduce the formatting legwork.

I also believe that if you merge in this merge commit, blackify your PR, then merge trunk, git should know what to do. If we squash merge PRs, then we'll also get a nice history for those PRs.

[twisted-trac]

	@glyph removed owner

[twisted-trac]

	@twm commented

The current PR for this appears to be #1134

[twisted-trac]

	@twm commented

Approved here: #1134 (review)

Thanks so much for this! It will make Twisted development much more pleasant.

[twisted-trac]

	@twm commented

New PR, since GitHub seemed a bit confused about the diff of the old one: #1380

[twisted-trac]

	@twm set owner to @twm @twm set status to closed

In changeset c5fbd88

#!CommitTicketReference repository="" revision="c5fbd88704d048f858a7b0e452992848af7a3825"
Merge pull request #1380 from twisted/9512-black-v2

Author: twm
Reviewer: rodrigc
Fixes: ticket:9512

Initial configuration for black