Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.w.c.ContentDecoderAgent docstring improvements #9742

Closed
twisted-trac opened this issue Dec 8, 2019 · 4 comments
Closed

t.w.c.ContentDecoderAgent docstring improvements #9742

twisted-trac opened this issue Dec 8, 2019 · 4 comments

Comments

@twisted-trac
Copy link

twm's avatar @twm reported
Trac ID trac#9742
Type enhancement
Created 2019-12-08 06:28:32Z
Branch https://github.com/twisted/twisted/tree/9742-contentdecoderagent-docs

twisted.web.client.ContentDecoderAgent's docstring doesn't document the type of the decoders parameter, and the example it gives --- (('gzip', GzipDecoder)) --- is actively misleading (should be b'gzip', wrong tuple syntax).

This verbiage is also unclear:

The name declares which decoding the decoder supports, and the decoder must return a response object when called/instantiated.

It should clarify that the decoder takes an IResponse and returns an IResponse.

The docstring should also be less ambiguous about where GzipDecoder lives.

Searchable metadata
trac-id__9742 9742
type__enhancement enhancement
reporter__twm twm
priority__normal normal
milestone__None None
branch__9742_contentdecoderagent_docs 9742-contentdecoderagent-docs
branch_author__ 
status__closed closed
resolution__fixed fixed
component__web web
keywords__None None
time__1575786512396559 1575786512396559
changetime__1585371509379060 1585371509379060
version__None None
owner__twm twm

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @twm
@twm set status to assigned

@twisted-trac
Copy link
Author

twm's avatar @twm removed owner
@twm set status to new

Ready for review: #1205

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @twm

Approved: #1205 (review)

@twisted-trac
Copy link
Author

twm's avatar @twm set status to closed

In changeset 40c5235

#!CommitTicketReference repository="" revision="40c523529ca235c13e0354d8b9bc934154dc323a"
Merge pull request #1205 from twisted/9742-contentdecoderagent-docs

Author: twm
Reviewer: rodrigc
Fixes: ticket:9742

Improve ContentDecoderAgent docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants