Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twisted.conch should use the new logging system #9773

Closed
twisted-trac opened this issue Mar 12, 2020 · 6 comments
Closed

twisted.conch should use the new logging system #9773

twisted-trac opened this issue Mar 12, 2020 · 6 comments

Comments

@twisted-trac
Copy link

ryban's avatar @ryban reported
Trac ID trac#9773
Type enhancement
Created 2020-03-12 00:34:22Z

twisted.logger is easier to work with to get the context of the log event and for setting log priorities. Each Logger should be a class attribute/descriptor so all of the events contain the instance to more easily know which connection generated the event.

Searchable metadata
trac-id__9773 9773
type__enhancement enhancement
reporter__ryban ryban
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__conch conch
keywords__log log
time__1583973262262503 1583973262262503
changetime__1597108259527645 1597108259527645
version__None None
owner__twm twm

@twisted-trac
Copy link
Author

ryban's avatar @ryban commented

PR: #1352

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @ryban

Review entered here: #1352 (review)

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @twm
@twm set status to assigned

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @ryban
@twm set status to new

Review here: #1352 (review) Very close!

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @twm
@twm set status to assigned

@twisted-trac
Copy link
Author

twm's avatar @twm set status to closed

In changeset 1675d6f

#!CommitTicketReference repository="" revision="1675d6fdb2732fc09de57003e8272324b470b751"
Merge pull request #1352 from ryban/9773-conch-logger

Author: ryban
Reviewer: twm
Fixes: ticket:9773

Use twisted.logger in conch instead of legacy logger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants