Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require passing CI for CPython 3.8 in Windows #9809

Closed
twisted-trac opened this issue May 5, 2020 · 6 comments
Closed

Require passing CI for CPython 3.8 in Windows #9809

twisted-trac opened this issue May 5, 2020 · 6 comments

Comments

@twisted-trac
Copy link

altendky's avatar @altendky reported
Trac ID trac#9809
Type enhancement
Created 2020-05-05 01:22:37Z

There has been confusion, see #9799#comment:9 as the central point of discussion.

Searchable metadata
trac-id__9809 9809
type__enhancement enhancement
reporter__altendky altendky
priority__normal normal
milestone__Python_3_8_Support Python 3.8 Support
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1588641757668012 1588641757668012
changetime__1600072597809031 1600072597809031
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

@twisted-trac
Copy link
Author

altendky's avatar @altendky commented

PR: #1259

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

#1338

@twisted-trac
Copy link
Author

altendky's avatar @altendky commented

'Review':
https://github.com/twisted/twisted/pull/1338/files#r483889472

This was already addressed by #1259 and doesn't need to be mixed with 1338 and #9766.

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

#1259 is a WIP and does not properly fix the reactor tests on Windows with Python 3.8. PR 1259 should be closed in favor of #1338

@twisted-trac
Copy link
Author

twm's avatar @twm commented

Approved on GitHub

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @rodrigc
@rodrigc set status to closed

In changeset d8203ca

#!CommitTicketReference repository="" revision="d8203ca6e51705bd6246e063722fcd8596b7cbd3"
Merge pull request #1338 from twisted/9766-rodrigc-asyncio-selecteventorloop

Author: rodrigc
Reviewer: twm
Fixes: ticket:9766 ticket:9809

Fix AsyncioSelectorReactor on Windows Python 3.8+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant