Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: fix error message: "Need type annotation" #9827

Closed
twisted-trac opened this issue May 12, 2020 · 3 comments
Closed

mypy: fix error message: "Need type annotation" #9827

twisted-trac opened this issue May 12, 2020 · 3 comments

Comments

@twisted-trac
Copy link

rodrigc's avatar @rodrigc reported
Trac ID trac#9827
Type enhancement
Created 2020-05-12 22:28:58Z

When running mypy with:

tox -e mypy

There are a bunch of errors like:

src/twisted/words/protocols/jabber/jid.py:108:1: error: Need type annotation for '__internJIDs' (hint: "__internJIDs: Dict[<type>, <type>] = ...")  [var-annotated]
    __internJIDs = {}

It would be good to clean those up

Searchable metadata
trac-id__9827 9827
type__enhancement enhancement
reporter__rodrigc rodrigc
priority__normal normal
milestone__publish_types publish types
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1589322538019498 1589322538019498
changetime__1594360403322407 1594360403322407
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

#1271

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

Approved here: #1271 (review)

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @rodrigc
@rodrigc set status to closed

In changeset 414d490

#!CommitTicketReference repository="" revision="414d490bb7811fb7b55cf2cfbf71f7a8b8527485"
Merge pull request #1271 from twisted/9827-rodrigc-mypy

Add more type annotations

Author: rodrigc
Reviewer: wsanchez
Fixes: ticket:9827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant