Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: Interface methods should not have 'self' argument #9837

Closed
twisted-trac opened this issue May 29, 2020 · 3 comments
Closed

mypy: Interface methods should not have 'self' argument #9837

twisted-trac opened this issue May 29, 2020 · 3 comments

Comments

@twisted-trac
Copy link

rodrigc's avatar @rodrigc reported
Trac ID trac#9837
Type defect
Created 2020-05-29 23:16:19Z

After running this commend:

tox -e mypy

I saw several errors like this:

src/twisted/protocols/haproxy/_interfaces.py:36:5: error: Interface methods should not have 'self' argument  [misc]
        def feed(self, data):
        ^
src/twisted/protocols/haproxy/_interfaces.py:52:5: error: Interface methods should not have 'self' argument  [misc]
        def parse(self, line):
        ^

It would be good to clean these errors up

Searchable metadata
trac-id__9837 9837
type__defect defect
reporter__rodrigc rodrigc
priority__normal normal
milestone__publish_types publish types
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1590794179274055 1590794179274055
changetime__1594360403322407 1594360403322407
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

#1280

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

Approved here: #1280 (review)

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @rodrigc
@rodrigc set status to closed

In changeset aac6b77

#!CommitTicketReference repository="" revision="aac6b775182dd2ddd9e6a6e9764e7d8172a68ab2"
Merge pull request #1280 from twisted/9837-rodrigc-fix-interfaces

Interface methods should not have 'self' argument

Author: rodrigc
Reviewer: adiroiban
Fixes: ticket:9837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant