Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _PY3 checks in a bunch of places #9842

Closed
twisted-trac opened this issue May 31, 2020 · 3 comments
Closed

Remove _PY3 checks in a bunch of places #9842

twisted-trac opened this issue May 31, 2020 · 3 comments

Comments

@twisted-trac
Copy link

rodrigc's avatar @rodrigc reported
Trac ID trac#9842
Type enhancement
Created 2020-05-31 17:29:43Z

Now that Twisted only supports Python 3.5 and higher,
we can remove checks for _PY3 in a bunch of places.

This eliminates a bunch of errors reported by mypy when doing:

tox -e mypy
Searchable metadata
trac-id__9842 9842
type__enhancement enhancement
reporter__rodrigc rodrigc
priority__normal normal
milestone__publish_types publish types
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1590946183124156 1590946183124156
changetime__1594360403322407 1594360403322407
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

#1285

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

Approved here: #1285 (review)

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @rodrigc
@rodrigc set status to closed

In changeset 70522c1

#!CommitTicketReference repository="" revision="70522c1b48b7a6ba29b18a080c12464d865b9e22"
Merge pull request #1285 from twisted/9842-rodrigc-no-py3

Remove some _PY3 checks and eliminate Python2 only code

Author: rodrigc
Reviewer: adiroiban
Fixes: ticket:9842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant