Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy to CI, but allow it to fail #9848

Closed
twisted-trac opened this issue Jun 9, 2020 · 3 comments
Closed

Add mypy to CI, but allow it to fail #9848

twisted-trac opened this issue Jun 9, 2020 · 3 comments

Comments

@twisted-trac
Copy link

rodrigc's avatar @rodrigc reported
Trac ID trac#9848
Type enhancement
Created 2020-06-09 03:55:07Z

We are at a point where we are able to add:

tox -e mypy

to the default CI for Twisted.
We need to allow it to fail in the CI, because this will allow the CI to pass, but we will be able to identify the existing errors and clean them up moving forward.

When we clean up all the mypy errors, we can convert it to a "must succeed" CI task.

Searchable metadata
trac-id__9848 9848
type__enhancement enhancement
reporter__rodrigc rodrigc
priority__normal normal
milestone__publish_types publish types
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1591674907008284 1591674907008284
changetime__1594360403322407 1594360403322407
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

#1290

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

Approved here: #1290 (review)

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @rodrigc
@rodrigc set status to closed

In changeset b7e55d4

#!CommitTicketReference repository="" revision="b7e55d42b450d2360a2a8f1f0306f9d153af423e"
Merge pull request #1290 from twisted/9848-rodrigc-mypy

Add mypy build to Azure pipelines

Author: rodrigc
Reviewer: adiroiban
Fixes: ticket:9848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant