Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce mypy errors (Part 16) #9869

Closed
twisted-trac opened this issue Jun 22, 2020 · 2 comments
Closed

Reduce mypy errors (Part 16) #9869

twisted-trac opened this issue Jun 22, 2020 · 2 comments

Comments

@twisted-trac
Copy link

rodrigc's avatar @rodrigc reported
Trac ID trac#9869
Type enhancement
Created 2020-06-22 06:28:38Z

This is a continuation of ticket:9867

We should add type annotations in a few places to reduce mypy warnings.

Searchable metadata
trac-id__9869 9869
type__enhancement enhancement
reporter__rodrigc rodrigc
priority__normal normal
milestone__publish_types publish types
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1592807318599902 1592807318599902
changetime__1594360403322407 1594360403322407
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

Approved here: #1314 (review)

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @rodrigc
@rodrigc set status to closed

In changeset 5a0f51d

#!CommitTicketReference repository="" revision="5a0f51d5731203852deb1049ddcda104e1f39970"
Merge pull request #1314 from twisted/9869-rodrigc-mypy

[mypy] Add some variable annotations

Author: rodrigc
Reviewer: adiroiban
Fixes: ticket:9869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant