Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce mypy errors (Part 24) #9882

Closed
twisted-trac opened this issue Jun 30, 2020 · 3 comments
Closed

Reduce mypy errors (Part 24) #9882

twisted-trac opened this issue Jun 30, 2020 · 3 comments

Comments

@twisted-trac
Copy link

rodrigc's avatar @rodrigc reported
Trac ID trac#9882
Type enhancement
Created 2020-06-30 19:39:58Z

This is a continuation of ticket:9880

It would be good to clean up these mypy errors:

src/twisted/protocols/amp.py:236:16: error: Module has no attribute "supported"  [attr-defined]
src/twisted/protocols/amp.py:1236:1: error: Cannot assign to a type  [misc]
src/twisted/protocols/amp.py:1236:18: error: Incompatible types in assignment (expression has type "__metaclass__", variable has type "Type[CommandLocator]")  [assignment]
src/twisted/protocols/amp.py:1236:18: note: "__metaclass__.__call__" has type "Callable[[VarArg(Any), KwArg(Any)], Any]"
src/twisted/protocols/amp.py:1825:19: error: Incompatible types in assignment (expression has type "Type[AmpBox]", variable has type "Type[Command]")  [assignment]
src/twisted/protocols/amp.py:2010:1: error: Cannot assign to a type  [misc]
src/twisted/protocols/amp.py:2010:11: error: Incompatible types in assignment (expression has type "__metaclass__", variable has type "Type[Command]")  [assignment]
src/twisted/protocols/amp.py:2010:11: note: "__metaclass__.__call__" has type "Callable[[VarArg(Any), KwArg(Any)], Any]"
src/twisted/protocols/amp.py:2080:5: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
Searchable metadata
trac-id__9882 9882
type__enhancement enhancement
reporter__rodrigc rodrigc
priority__normal normal
milestone__publish_types publish types
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1593545998569069 1593545998569069
changetime__1594360403322407 1594360403322407
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

#1327

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

Approved here: #1327 (review)

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @rodrigc
@rodrigc set status to closed

In changeset 16b0756

#!CommitTicketReference repository="" revision="16b07561bb1823581c0d1963c86169ac10c9cbb5"
Merge pull request #1327 from twisted/9882-rodrigc-mypy

[mypy] [9882] Reduce mypy errors

Author: rodrigc
Reviewer: adiroiban
Fixes: ticket:9882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant