Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce mypy errors (Part 33) #9896

Closed
twisted-trac opened this issue Jul 7, 2020 · 3 comments
Closed

Reduce mypy errors (Part 33) #9896

twisted-trac opened this issue Jul 7, 2020 · 3 comments

Comments

@twisted-trac
Copy link

rodrigc's avatar @rodrigc reported
Trac ID trac#9896
Type enhancement
Created 2020-07-07 19:37:12Z

This is a continuation of ticket:9895

It would be good to clean up this mypy error:

src/twisted/_threads/test/test_team.py:11:1: error: Module 'twisted.python.context' has no attribute 'call'  [attr-defined]
    from twisted.python.context import call, get
    ^
src/twisted/_threads/test/test_team.py:11:1: error: Module 'twisted.python.context' has no attribute 'get'  [attr-defined]
    from twisted.python.context import call, get
Searchable metadata
trac-id__9896 9896
type__enhancement enhancement
reporter__rodrigc rodrigc
priority__normal normal
milestone__publish_types publish types
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1594150632576823 1594150632576823
changetime__1594360403322407 1594360403322407
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

#1340

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

Approved here: #1340 (review)

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @rodrigc
@rodrigc set status to closed

In changeset b88b271

#!CommitTicketReference repository="" revision="b88b2714419b3538f1a0c12c11993aa5cef9eaa9"
Merge pull request #1340 from twisted/9896-rodrigc-mypy

[mypy] [9896] Reduce mypy errors: explicitly define global variables in context module

Author: rodrigc
Reviewer: adiroiban
Fixes: ticket:9896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant