Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce mypy errors (Part 38) #9901

Closed
twisted-trac opened this issue Jul 9, 2020 · 3 comments
Closed

Reduce mypy errors (Part 38) #9901

twisted-trac opened this issue Jul 9, 2020 · 3 comments

Comments

@twisted-trac
Copy link

rodrigc's avatar @rodrigc reported
Trac ID trac#9901
Type enhancement
Created 2020-07-09 05:18:24Z

This is a continuation of ticket:9900

It would be good to clean up this mypy error:

src/twisted/words/im/basesupport.py:130:16: error: "AbstractClientMixin" has no attribute "_protoBase"  [attr-defined]
            return self._protoBase.connectionLost(self, reason)

Searchable metadata
trac-id__9901 9901
type__enhancement enhancement
reporter__rodrigc rodrigc
priority__normal normal
milestone__publish_types publish types
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__words words
keywords__None None
time__1594271904711606 1594271904711606
changetime__1594360403322407 1594360403322407
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

#1345

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc commented

Approved here: #1345 (review)

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @rodrigc
@rodrigc set status to closed

In changeset 74487b2

#!CommitTicketReference repository="" revision="74487b298f1de88c787ad3b15d52bbd762fd34b4"
Merge pull request #1345 from twisted/9901-rodrigc-mypy

[mypy] [9901] Eliminate mypy error in src/twisted/words/im/basesupport.py

Author: rodrigc
Reviewer: adiroiban
Fixes: ticket:9901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant