Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate obsolete public definitions from twisted.python.compat #9922

Closed
twisted-trac opened this issue Jul 22, 2020 · 3 comments
Closed

Deprecate obsolete public definitions from twisted.python.compat #9922

twisted-trac opened this issue Jul 22, 2020 · 3 comments

Comments

@twisted-trac
Copy link

mthuurne's avatar @mthuurne reported
Trac ID trac#9922
Type enhancement
Created 2020-07-22 22:25:08Z

This is the public counterpart to #9921. There are a lot of definitions that were useful in the transition to Python 3 but no longer serve a purpose.

Twisted can stop using these internally right now. In case there are external users, we should deprecate them, so we can remove the obsolete definitions at some point in the future.

Searchable metadata
trac-id__9922 9922
type__enhancement enhancement
reporter__mthuurne mthuurne
priority__normal normal
milestone__De_Python_2ify De-Python-2ify
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1595456708659540 1595456708659540
changetime__1598570326806290 1598570326806290
version__None None
owner__mthuurne mthuurne

@twisted-trac
Copy link
Author

mthuurne's avatar @mthuurne commented

PR is ready for review: #1364

@twisted-trac
Copy link
Author

wsanchez's avatar @wsanchez set owner to @mthuurne

Reviewed. Note minor comments, and the merge conflict, but you're good to go.

@twisted-trac
Copy link
Author

mthuurne's avatar @mthuurne set status to closed

In changeset 9799391

#!CommitTicketReference repository="" revision="97993912c2667b0b311c01794535addd65ce36df"
Merge pull request #1364 from twisted/9922-mthuurne-cleanup_compat_public

Deprecate obsolete public definitions from twisted.python.compat

Author: mthuurne
Reviewer: wsanchez
Fixes: ticket:9922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant