Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twisted.internet.process.Process.(pause|resume)Producing broken on py3 #9933

Closed
twisted-trac opened this issue Aug 8, 2020 · 4 comments
Closed

Comments

@twisted-trac
Copy link

graingert's avatar @graingert reported
Trac ID trac#9933
Type enhancement
Created 2020-08-08 09:06:50Z

https://github.com/twisted/twisted/blame/78032afbc70639a2eafdc57933140eb76465f85d/src/twisted/internet/process.py#L854-L863

uses .itervalues() which is unavailable in py3, also missing documention/examples and tests

Searchable metadata
trac-id__9933 9933
type__enhancement enhancement
reporter__graingert graingert
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1596877610179660 1596877610179660
changetime__1616717504288730 1616717504288730
version__None None
owner__ndg63276 ndg63276

@twisted-trac
Copy link
Author

ndg63276's avatar @ndg63276 commented

python/compat.py has a itervalues() function which should be used instead for py2/py3 compatibility.

@twisted-trac
Copy link
Author

ndg63276's avatar @ndg63276 commented

#1478

@twisted-trac
Copy link
Author

exarkun's avatar @exarkun set owner to @ndg63276

I think Thomas reviewed the PR 3 weeks ago. #1478 (review)

@twisted-trac
Copy link
Author

wiml's avatar @wiml set status to closed

In changeset 40f0d2c

#!CommitTicketReference repository="" revision="40f0d2c95089352fd0002ae6c3772fe2410a0120"
Merge pull request #1478 from ndg63276/9933-ndg63276-mychange

Author: ndg63276
Reviewer: graingert, auvipy, wiml
Fixes: ticket:9933

fix twisted.internet.process.pauseProducing/resumeProducing for python 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant