Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code that only runs on unsupported Python versions #9936

Closed
twisted-trac opened this issue Aug 8, 2020 · 3 comments
Closed

Remove code that only runs on unsupported Python versions #9936

twisted-trac opened this issue Aug 8, 2020 · 3 comments

Comments

@twisted-trac
Copy link

mthuurne's avatar @mthuurne reported
Trac ID trac#9936
Type task
Created 2020-08-08 22:12:04Z

There are several places in the code (mostly in tests) where sys.version_info is checked in ways that either always result in True or always result in False on Python versions that Twisted still supports.

Searchable metadata
trac-id__9936 9936
type__task task
reporter__mthuurne mthuurne
priority__normal normal
milestone__De_Python_2ify De-Python-2ify
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1596924724401973 1596924724401973
changetime__1597536458977250 1597536458977250
version__None None
owner__mthuurne mthuurne

@twisted-trac
Copy link
Author

mthuurne's avatar @mthuurne commented

PR is ready for review: #1372

This one is relatively small and straightforward.

@twisted-trac
Copy link
Author

wsanchez's avatar @wsanchez set owner to @mthuurne

reviewed, LGTM

@twisted-trac
Copy link
Author

mthuurne's avatar @mthuurne set status to closed

In changeset 62ae75d

#!CommitTicketReference repository="" revision="62ae75dfa76de1e4db515fc6390171ba3e9160a7"
Merge pull request #1372 from twisted/9936-mthuurne-remove_code_for_unsupported_versions

Remove code that only runs on unsupported Python versions

Author: mthuurne
Reviewer: wsanchez
Fixes: ticket:9936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant