Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreachable code from twisted.persisted #9977

Closed
twisted-trac opened this issue Sep 25, 2020 · 3 comments
Closed

Remove unreachable code from twisted.persisted #9977

twisted-trac opened this issue Sep 25, 2020 · 3 comments
Assignees
@wsanchez
Labels
core enhancement fixed priority-normal

Comments

@twisted-trac
Copy link

wsanchez's avatar @wsanchez reported
Trac ID trac#9977
Type enhancement
Created 2020-09-25 18:02:28Z

mypy.ini disables warn_unreachable for some files in twisted.persisted.

Remove the unreachable code and enable warn_unreachable for those files.

Searchable metadata 
trac-id__9977 9977
type__enhancement enhancement
reporter__wsanchez wsanchez
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1601056948042863 1601056948042863
changetime__1601069953325301 1601069953325301
version__None None
owner__wsanchez wsanchez
@twisted-trac
Copy link
Author

wsanchez's avatar @wsanchez commented

PR: #1402

@twisted-trac
Copy link
Author

wsanchez's avatar @wsanchez set owner to @wsanchez

reviewed by rodrigc

@twisted-trac
Copy link
Author

wsanchez's avatar @wsanchez set status to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsanchez wsanchez

Labels
core enhancement fixed priority-normal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wsanchez @twisted-trac