Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twistedchecker thinks a '#' in a string starts a comment, complains #121

Closed
wsanchez opened this issue Dec 7, 2016 · 2 comments
Closed

twistedchecker thinks a '#' in a string starts a comment, complains #121

wsanchez opened this issue Dec 7, 2016 · 2 comments
Labels
type-defect

Comments

@wsanchez
Copy link
Member

wsanchez commented Dec 7, 2016

I made this change: twisted/twisted@9c0d56c

Because:

  • W9401: Comments should begin with one whitespace
  • W9402: The first letter of comment should be capitalized

See: https://travis-ci.org/twisted/twisted/jobs/181781383
@adiroiban
Copy link
Member

This looks like a duplicate for #103 and #110

@wsanchez
Copy link
Member Author

wsanchez commented Dec 7, 2016

#103 is about capitalization requirements in comments, and seems unrelated.

This is a dup of #110, though.

@wsanchez wsanchez closed this as completed Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wsanchez @adiroiban