Check interface implementations for correct argument names

[ghost]

For example, FilePath.child, IFilePath.child and ZipFile.child use different argument names, which means that you can't be certain that it is safe to call the child method with keyword arguments.

• https://twistedmatrix.com/documents/current/api/twisted.python.filepath.IFilePath.html#child
• https://twistedmatrix.com/documents/current/api/twisted.python.filepath.FilePath.html#child
• https://twistedmatrix.com/documents/current/api/twisted.python.zippath.ZipArchive.html#child
• https://twistedmatrix.com/documents/current/api/twisted.python.zippath.ZipPath.html#child

Maybe it would also be a good idea for twistedchecker to automatically to zope.interface.verify.verifyClass tests, except that would require actually importing the module.

---

Imported from Launchpad using lp2gh.

• date created: 2013-10-20T13:33:28Z
• owner: richardw
• the launchpad url was https://bugs.launchpad.net/bugs/1242341

[adiroiban]

I am not sure if this is the right place to do this check.
It would need to import the module and the interface... and you might have modules which are only loaded on a specific OS so you would need to run the checker on multiple operating systems

For my project, for each class I have a test_initialization unit test, in which I check for interface implementation using a test helper.

Maybe we can update the Twisted reviewer's check list and add a note that for new classes we need a test against interface implementation.

@wallrj please add your feedback on this.