Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just link necessary libraries #404

Closed
wants to merge 1 commit into from
Closed

Conversation

Jamyw7g
Copy link

@Jamyw7g Jamyw7g commented Dec 30, 2022

Just need to link necessary libraries.

No matter what feature I use, it will link all libraries, but this is not necessary. And it slow down program startup.

@twistedfall
Copy link
Owner

Hi, thanks for the PR! Unfortunately it's not that easy. OpenCV allows building in a configurations where there is only 1 dynamic library called opencv_world which contains the code for all enabled modules. But in your case, does specifying just OPENCV_LINK_LIBS environment variable not work? It should overwrite the list of libraries that would be linked. If it doesn't work maybe there is a bug in the build.rs.

@Jamyw7g
Copy link
Author

Jamyw7g commented Dec 30, 2022

OPENCV_LINK_LIBS may not be convenient. features may be very straightforward and convenient. Maybe my implementation is not very well yet. I think you can consider it.

@twistedfall
Copy link
Owner

I'm going to close this PR due to the reasons that this implementation won't work universally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants