Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of attributes in USERNOTICE for resub #211

Open
sogehige opened this issue Feb 5, 2019 · 3 comments
Open

Change of attributes in USERNOTICE for resub #211

sogehige opened this issue Feb 5, 2019 · 3 comments

Comments

@sogehige
Copy link

sogehige commented Feb 5, 2019

Expected behaviour

Correct data parsed from twitch tmi

We should be able to parse msg-param-cumulative-months which replaces msg-param-months

Actual behaviour

Incorrect data

Steps to reproduce

Twitch changed its resubs https://dev.twitch.tv/docs/release-notes/

Chatbots & IRC: Twitch Tags: For USERNOTICE, added three fields (msg-param-cumulative-months, msg-param-should-share-streak, msg-param-streak-months) and changed when msg-param-months is sent.

Your environment

  • Operating system(s):
  • TwitchJS version:
  • NodeJS version:
  • Browser(s):
@marcandrews
Copy link
Member

marcandrews commented Feb 5, 2019

Hmm, I am a bit surprised.

There is minimal processing on tags, so they should be available in .tags.

Any tags beginning with msg-param should available in .parameters. The only problem is that new/changed message parameters may be incorrectly typed (i.e. string instead number).

For example, msg-param-cumulative-months should be available at .tags.msgParamCumulativeMonths and .parameters.cumulativeMonths.

@sogehige
Copy link
Author

sogehige commented Feb 5, 2019

Hmm, I thought that may be case but didn't have time to check how its processed actually. Ok, so I guess I create wrong issue, shame on me 👎

@sogehige sogehige closed this as completed Feb 5, 2019
@marcandrews
Copy link
Member

Let's keep this open. We still should ensure that the types are correct in .parameters.

@marcandrews marcandrews reopened this Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants