Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Chat method timeouts #282

Open
marcandrews opened this issue Dec 30, 2020 · 0 comments
Open

Feature: Chat method timeouts #282

marcandrews opened this issue Dec 30, 2020 · 0 comments

Comments

@marcandrews
Copy link
Member

Sorry @victorperin, but I had to remove all timeout functionality because if the message is queued, it may cause the timeout for the confirmation event to expire even though the message has yet to be sent.

I did however replace the resolveOnEvent with p-event that supports timeouts. I am thinking about adding and optional options?: { timeout?: number } parameter to all Chat methods that send messages, such as Chat#join and Chat#say, so you can pass a timeout to p-event and timeout methods if needed.

Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant