Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for parameters and keep-alive signal #18

Merged
merged 2 commits into from Jan 4, 2022

Conversation

dee-gmiterko
Copy link
Contributor

Hi,
I encountered two issues when using your library, namely:

@saadmanrafat
Copy link
Member

Thank you for the @linzee. I'm getting back to you asap!

@saadmanrafat saadmanrafat self-assigned this Jan 4, 2022
@saadmanrafat
Copy link
Member

"Fields included in _exclude would ignore list of API endpoint altogether instead of using names without does as intended."

Adding _exclude was a bad design -- I have to live with it till another major release. Which will be asap -- I guess. Thanks for pull requested!

@saadmanrafat saadmanrafat merged commit ab22af6 into twitivity:main Jan 4, 2022
@saadmanrafat saadmanrafat self-requested a review January 4, 2022 23:56
@saadmanrafat
Copy link
Member

@linzee, I am uploading the latest release to PyPI. We are working on covering more v2 endpoints In a separate tool. Thanks for the contribution.

@dee-gmiterko
Copy link
Contributor Author

Thank you, I am looking forward to the new tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants