Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

util.makeContiguous #123

Closed
mys007 opened this issue May 22, 2016 · 1 comment
Closed

util.makeContiguous #123

mys007 opened this issue May 22, 2016 · 1 comment

Comments

@mys007
Copy link

mys007 commented May 22, 2016 •
edited

I am confused by the meaning of util.makeContiguous and its gradient being defined as zeroGradient(). There is also torch.contiguous() doing IMHO the same job, but having gradient function(g,ans,x) return g end. I have a strong feeling this is wrong. I have noticed this when trying to figure out why there is no backpropagation through torch.view(). I suggest util.makeContiguous get removed completely.
@alexbw
Copy link
Collaborator

alexbw commented May 23, 2016

You are correct, and I remove util.makeContiguous today and merge. GitHub is having some issues, so will do after the storm passes.

@alexbw alexbw mentioned this issue May 24, 2016
Merged
@alexbw alexbw closed this as completed May 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexbw @mys007