Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix graph tool segmentation fault #99

Merged
merged 1 commit into from May 1, 2022

Conversation

lrnzgiusti
Copy link
Contributor

@lrnzgiusti lrnzgiusti commented May 1, 2022

This pull request fixes a SIGSEGV from graph-tool=2.44 when calling gt.stats in function cwn.data.utils.get_rings

as noted in graph_tool doc:

# import numpy and scipy before everything to avoid weird segmentation faults
# depending on the order things are imported.

I haven't run an exhaustive debugging but importing numpy or torch before graph_tool leads to a segfault while computing the rings of a graph.

This code will reproduce the error:

Schermata 2022-05-01 alle 12 28 57

After changing the position of import graph_tool as gt

Schermata 2022-05-01 alle 12 30 17

(I set the matrix-style terminal many years ago and never changed, sorry for that ahah)

@lrnzgiusti lrnzgiusti marked this pull request as ready for review May 1, 2022 10:33
@crisbodnar
Copy link
Collaborator

Thanks for the PR! Merged.

@crisbodnar crisbodnar merged commit e88ea25 into twitter-research:main May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants