This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
updates for building in Xcode 8.3 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- accept build recommendations CLANG_WARN_BOOL_CONVERSION = YES CLANG_WARN_CONSTANT_CONVERSION = YES CLANG_WARN_ENUM_CONVERSION = YES CLANG_WARN-INFINITE_RECURSION = YES CLANG_WARN_INT_CONVERSION = YES CLANG_WARN_SUSPICIOUS_MOVE = YES CLANG_WARN_UNREACHABLE_CODE = YES ENBALE_STRICT_OBJC_MSGSEND = YES GCC_NO_COMMON_BLOCKS = YES GCC_WARN_UNDECLARED_SELECTOR = YES GCC_WARN_UNUSED_FUNCTION = YES - fix one instance in SPDYLogginTest.m of accepting nil as value for an enum type by casting the nil to enum (so the value can still be compared for the expected enumeral) - update lastVersionCheck/lastVersionUpgrade to 0830
|
i figured so long as all of these warnings didn't create a huge number of new issues to repair, it would be useful to accept them this one time, and then future upgrades would have a higher signal:noise ratio when looking at Xcode upgrade recommendations. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accept build recommendations going forward
CLANG_WARN_BOOL_CONVERSION = YES
CLANG_WARN_CONSTANT_CONVERSION = YES
CLANG_WARN_ENUM_CONVERSION = YES
CLANG_WARN-INFINITE_RECURSION = YES
CLANG_WARN_INT_CONVERSION = YES
CLANG_WARN_SUSPICIOUS_MOVE = YES
CLANG_WARN_UNREACHABLE_CODE = YES
ENBALE_STRICT_OBJC_MSGSEND = YES
GCC_NO_COMMON_BLOCKS = YES
GCC_WARN_UNDECLARED_SELECTOR = YES
GCC_WARN_UNUSED_FUNCTION = YES
fix one instance in SPDYLogginTest.m of
accepting nil as value for an enum type by
casting the nil to enum (so the value can
still be compared for the expected enumeral)
update lastVersionCheck/lastVersionUpgrade to 0830