This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Avoid use of CFAbsoluteTime as much as possible. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A helper class SPDYStopwatch is introduced here to abstract common time management duties from the rest of the code. Since CFAbsoluteTimeGetCurrent() is affected by clock and timezone changes, it's use should be avoided. mach_absolute_time() is unaffected by clock changes, but is susceptible to overflow issues (which can be worked around) and doesn't increment while the system is asleep (which cannot be worked around). However, it has more appropriate behavior. Our use of CFAbsoluteTimeGetCurrent() for the timers is unavoidable, since Cocoa timers are based on it. This seems like it would present undesirable behavior for our deferrable and connect timers if the clock were to change, but there's not much to do about it.
kgoodier
force-pushed
the
review/absolute-time
branch
from
ddddd10
to
7c1a4f1
Compare
After discussion, we decided to revert back to using CFAbsoluteTime for timing operations. There are pros and cons of each approach, and it boiled down to basically "keep doing what we were doing since it wasn't obviously broken". This will keep the metadata timing values consistent. The things being measured -- latency, connected time -- are really wall-time measurements, and having them affected by sleep time is odd.
goaway
added a commit
that referenced
this pull request
Nov 27, 2014
Avoid use of CFAbsoluteTime as much as possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A helper class SPDYStopwatch is introduced here to abstract common
time management duties from the rest of the code.
Since CFAbsoluteTimeGetCurrent() is affected by clock and timezone
changes, it's use should be avoided. mach_absolute_time() is unaffected
by clock changes, but is susceptible to overflow issues (which can be
worked around) and doesn't increment while the system is asleep (which
cannot be worked around). However, it has more appropriate behavior.
Our use of CFAbsoluteTimeGetCurrent() for the timers is unavoidable,
since Cocoa timers are based on it. This seems like it would present
undesirable behavior for our deferrable and connect timers if the clock
were to change, but there's not much to do about it.