Skip to content
This repository has been archived by the owner on Jan 23, 2020. It is now read-only.

Hackweek #46

Merged
merged 45 commits into from Jan 12, 2013
Merged

Hackweek #46

merged 45 commits into from Jan 12, 2013

Conversation

sagemintblue
Copy link
Contributor

Most significant changes:

  • All client javascript code has been refactored / rewritten
  • All Azkaban graph layout java code has been removed
  • The existing DAG view has been replaced

I've tested these updates extensively with the demo data, but only with a few actual scripts via pig local mode. However, stability should already be improved as the Azkaban code would through NPEs for some job graphs (those with disconnected components).

Still TBD:

  • The chord and graph views don't resize with changes to viewport dimensions; The page must be reloaded to properly resize those views.
  • The view colors and other theme related params should be centralized within core Ambrose object.

- Reorients circle such that first job is just after 12 o'clock
- Reorients job index text labels to avoid up-side down display
I'll remove these once I've finished the modularization.
@ghost ghost assigned billonahill Jan 12, 2013
sagemintblue added a commit that referenced this pull request Jan 12, 2013
@sagemintblue sagemintblue merged commit 099b4df into twitter-archive:master Jan 12, 2013
@caniszczyk
Copy link
Contributor

Awesome!

On a related note, I don't see any tests running after a build:

837-------------------------------------------------------
838 T E S T S
839-------------------------------------------------------
840
841Results :
842
843Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

Was this always the case?

@caniszczyk
Copy link
Contributor

It's also probably worth tagging a v0.2.0 sooner or later ;)

@sagemintblue
Copy link
Contributor Author

True.. We've never had a formal release of Ambrose as it depends on Pig 0.11.0-SNAPSHOT. Once there's a legitimate Pig 0.11.0 jar in Maven Central we'll go ahead with an Ambrose release at whatever version makes sense :)

Unit tests still TBD unfortunately.

@caniszczyk
Copy link
Contributor

Need to bribe @julienledem to do a release. All the kids these days love agile and releasing often ;)

@sagemintblue
Copy link
Contributor Author

Oh, I've looped J_ in for sure-- We spoke today about how best to get Ambrose shipped for use in the office. This branch in master is one of a handful of steps I need to complete before we have Ambrose available on all our gateway hosts.

@billonahill
Copy link
Contributor

Andy, this is great. Loving all the merge notifications coming through.

Chris, J_ and I also spoke about how to push on the remaining patches that are blocking the Pig 11 release. We really need to get 11 shipped...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants