Skip to content
This repository has been archived by the owner on Jan 23, 2020. It is now read-only.

Adds text to clarify current dashboard filter values #92

Conversation

sagemintblue
Copy link
Contributor

Addresses #82 by adding a line of text between the "Workflows" h2 and the table of workflows itself which conforms to pattern:

Workflows on $cluster with status $status and user $user.

$status and $user default to "any".

There may be more elegant ways to work this into the design, but the dropdown menus within the navbar don't look at all good if I include their current value in the text label and dynamically change it when filter value is updated. The resulting shifting of other navbar elements is not so nice.

@billonahill
Copy link
Contributor

Code looks good, but can we render this info in a way that's not so intrusive? It takes up a lot of real estate on the screen with the Wolkflows and the filter settings below.

ambrose_dashboard-2

@sagemintblue
Copy link
Contributor Author

How about simply removing the h2 "Workflows" above it?

On Mon, Jul 29, 2013 at 10:23 PM, Bill Graham notifications@github.comwrote:

Code looks good, but can we render this info in a way that's not so
intrusive? It takes up a lot of real estate on the screen with the
Wolkflows and the filter settings below.

[image: ambrose_dashboard-2]https://f.cloud.github.com/assets/23758/876703/18e388ca-f8d8-11e2-9762-f85a3e99ef29.png


Reply to this email directly or view it on GitHubhttps://github.com//pull/92#issuecomment-21770330
.

@billonahill
Copy link
Contributor

Yes, let's try removing Workflows. Can we also reduce the size of the
filter statement? It should be somewhat subtle.

On Tue, Jul 30, 2013 at 9:30 AM, Andy Schlaikjer
notifications@github.comwrote:

How about simply removing the h2 "Workflows" above it?

On Mon, Jul 29, 2013 at 10:23 PM, Bill Graham notifications@github.comwrote:

Code looks good, but can we render this info in a way that's not so
intrusive? It takes up a lot of real estate on the screen with the
Wolkflows and the filter settings below.

[image: ambrose_dashboard-2]<
https://f.cloud.github.com/assets/23758/876703/18e388ca-f8d8-11e2-9762-f85a3e99ef29.png>


Reply to this email directly or view it on GitHub<
https://github.com/twitter/ambrose/pull/92#issuecomment-21770330>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/92#issuecomment-21803819
.

@sagemintblue
Copy link
Contributor Author

I tried normal sizing of the text, but didn't like it as much; Looks
incongruous with respect to the table below and any content in there.

@sagemintblue
Copy link
Contributor Author

image

billonahill pushed a commit that referenced this pull request Aug 5, 2013
Adds text to clarify current dashboard filter values
@billonahill billonahill merged commit 09d804e into twitter-archive:master Aug 5, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants