Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScroogeCodecLaws is flaky #211

Closed
jnievelt opened this issue May 8, 2015 · 3 comments
Closed

ScroogeCodecLaws is flaky #211

jnievelt opened this issue May 8, 2015 · 3 comments

Comments

@jnievelt
Copy link
Contributor

jnievelt commented May 8, 2015

Looks like we're testing JsonScalaCodec beyond its limits. Various unicode strings can fail to round-trip, causing the test to (usually) fail. This seems to be a limitation of the underlying protocol/serializer, and the correct approach is probably to constrain the set of strings tested.
@ianoc
Copy link
Collaborator

ianoc commented May 18, 2015

This was fixed in #214

@sritchie sritchie closed this as completed Dec 8, 2015
@sritchie
Copy link
Collaborator

sritchie commented Dec 8, 2015

I'm scrounging around for scala issues. Closing this one, since it looks like it's fixed.

@johnynek
Copy link
Collaborator

johnynek commented Dec 8, 2015

Nice to see you around here, @sritchie !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@johnynek @sritchie @ianoc @jnievelt