Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter Bootstrap is incompatible with jQuery UI styles #156

Closed
ianmurrays opened this issue Sep 4, 2011 · 31 comments
Closed

Twitter Bootstrap is incompatible with jQuery UI styles #156

ianmurrays opened this issue Sep 4, 2011 · 31 comments

Comments

@ianmurrays
Copy link

I'm trying to use jQuery UI's datepicker and the calendar looks awful, because of how bootstrap styles tables (among other things). Is there a workaround for this?

@nikku
Copy link

nikku commented Sep 5, 2011

There is none at the moment unless you completely reset the css styles for the specified table (use Firebug or what ever your favourite tool for web development is, get the table styles and create your own css class which resets these styles to default).

This is a general issue, as bootstrap applies styles in a very general fashion (see #141). In first releases one had to add .commons-table to apply the table styles while the style is now applied to all table elements.

@StephenPower
Copy link

Amen to this, I just spent an hour doing exactly what Nikku said...

@nikku
Copy link

nikku commented Sep 7, 2011

I will create a new issue for that, as it is a general problem which deserves consideration in new releases of the CSS toolkit.

@ldbglobe
Copy link

As a workaround you can change apply rules for table in the les file to return on the original comportment and compile again

releases one had to add .commons-table to apply the table styles while the style is now applied to all table elements.

@ianmurrays
Copy link
Author

That is one solution, although it does not fix the issue
unfortunately, since there are many other styles that interfere with
jquery ui's styles (or viceversa :P).

On 12-09-2011, at 10:42, ldbglobe
reply@reply.github.com
wrote:

As a workaround you can change apply rules for table in the les file to return on the original comportment and compile again

releases one had to add .commons-table to apply the table styles while the style is now applied to all table elements.

Reply to this email directly or view it on GitHub:
#156 (comment)

@mdo
Copy link
Member

mdo commented Sep 12, 2011

While we certainly don't want to have conflicts wherever possible, making Bootstrap work 100% with jQuery UI (or any other library for that matter) is likely a significant time investment. We'll have to do our best as we go to make this as easy as possible by doing things like this.

In v2.0.0, we're thinking about bringing back classes for elements like tables and forms. I really do hate adding the extra markup though, so that's the balancing act we're looking at.

@ianmurrays
Copy link
Author

Maybe find a way to kind of sandbox jquery-ui's styles? I made an attempt at that but unsuccessfuly :(

On 12-09-2011, at 14:02, Mark Otto wrote:

While we certainly don't want to have conflicts wherever possible, making Bootstrap work 100% with jQuery UI (or any other library for that matter) is likely a significant time investment. We'll have to do our best as we go to make this as easy as possible by doing things like this.

In v2.0.0, we're thinking about bringing back classes for elements like tables and forms. I really do hate adding the extra markup though, so that's the balancing act we're looking at.

Reply to this email directly or view it on GitHub:
#156 (comment)

Ian Murray
twitter.com/Synt4x · fb.com/ianmurrays · github.com/ianmurrays
Linkworks (www.linkworks.cl)

@nikku
Copy link

nikku commented Sep 12, 2011

Again, a nice thing to provide would be "reset-bootstrap-style" classes for contextual elements in which forms, tables and so on only get basic styles (if any) applied. This would allow developers to use tables without styling if explicitly desired.

I know this would blow up bootstrap quite a bit. Maybe it could just be provided as some sort of extension to it.

@fat
Copy link
Member

fat commented Sep 12, 2011

Maybe someone will get inspired and just build a jquery-ui theme that uses bootstrap? Doesn't seem like it would be too hard.

@ianmurrays
Copy link
Author

That would be awesome!

On 12-09-2011, at 15:48, Jacob Thornton wrote:

Maybe someone will get inspired and just build a jquery-ui theme that uses bootstrap? Doesn't seem like it would be too hard.

Reply to this email directly or view it on GitHub:
#156 (comment)

Ian Murray
twitter.com/Synt4x · fb.com/ianmurrays · github.com/ianmurrays
Linkworks (www.linkworks.cl)

@mdo
Copy link
Member

mdo commented Sep 13, 2011

Closing this issue—please follow along on #171 as we revisit some classes in v2.0.

@mdo mdo closed this as completed Sep 13, 2011
@necks
Copy link

necks commented Sep 19, 2011

I've been working on a .less file that uses the bootstrap variables and mixins to replace the default jQuery UI theme. It's working pretty well for some of the features. Unfortunately it still requires the icons sprite.

@ianmurrays
Copy link
Author

That's great though! Can't wait to see that ;)

Ian Murray S.
Twitter: @synt4x
GitHub: ianmurrays
Skype: ianmurrays

On 19-09-2011, at 12:35, necks
reply@reply.github.com
wrote:

I've been working on a .less file that uses the bootstrap variables and mixins to replace the default jQuery UI theme. It's working pretty well for some of the features. Unfortunately it still requires the icons sprite.

Reply to this email directly or view it on GitHub:
#156 (comment)

@jmcmichael
Copy link

Yeah me too! :)

@necks
Copy link

necks commented Sep 30, 2011

Hi, here is a pack with the less for Jquery UI. It's still in progress and some parts may look unrelated. But it think the sliders and the datepickers look good. http://neckssoft.eu/download.php?download=twitter-bootstrap-jqueryui-less

@devinus
Copy link

devinus commented Oct 4, 2011

@necks how is the conversion today? Are you still working on it?

@necks
Copy link

necks commented Oct 5, 2011

@devinus I'm not working on it at the moment. But I promise I'll come back to it.

@thbar
Copy link

thbar commented Oct 27, 2011

Is there anyone (apart from the work provided by @necks) with a working date-picker for bootstrap, or with partial fixes to make only the jquery-ui datepicker work?

My guess is that most people are actually trying to remove the styling in jquery-ui, to get something minimalistic which fits bootstrap :)

@bbenezech
Copy link

@thbar
Copy link

thbar commented Oct 27, 2011

@bbenezech thanks a ton!

@thbar
Copy link

thbar commented Oct 27, 2011

For those interested by @bbenezech example, here's the direct link with the date picker: http://rails-admin-tb.herokuapp.com/admin/drafts/new

@lightglitch
Copy link

Nice, I will use aristo theme as base convert it to less and add it to

https://github.com/lightglitch/bootstrap-xtra

@jhherren
Copy link

I figured out a quick fix that worked for me using an autocomplete widget. Create a custom theme with themeroller, then on the download page, choose 'Advanced Theme Settings'. Set the CSS scope to 'body'. Since the CSS rules you download will be prefixed with the body tag selector, they'll have higher specificity and will override bootstrap rules.

I've only tested this for an autocomplete widget but it seemed to work perfectly.

@thbar
Copy link

thbar commented Nov 10, 2011

Hey John - thanks a ton, that's a great tip!

Le 10 nov. 2011 à 07:36, John Herren
reply@reply.github.com
a écrit :

I figured out a quick fix that worked for me using an autocomplete widget. Create a custom theme with themeroller, then on the download page, choose 'Advanced Theme Settings'. Set the CSS scope to 'body'. Since the CSS rules you download will be prefixed with the body tag selector, they'll have higher specificity and will override bootstrap rules.

I've only tested this for an autocomplete widget but it seemed to work perfectly.


Reply to this email directly or view it on GitHub:
#156 (comment)

@huug
Copy link

huug commented Dec 13, 2011

@jhherren tnx for the tip! It also works fine with the datepicker widget!

@jhherren
Copy link

jhherren commented Jan 6, 2012

@devinus
Copy link

devinus commented Jan 6, 2012

@jhherren This is awesome man!

@jslegers
Copy link

jjQuery Bootstrap merges the features of Bootstrap 1.4 with the jQuery UI CSS framework ---> http://jslegers.github.com/jquery-bootstrap/

@thbar
Copy link

thbar commented Feb 24, 2012

Is that still the case with boostrap 2?

@thbar
Copy link

thbar commented Feb 24, 2012

ah ! just saw mark comment - looks like moving to bootstrap 2 is the way to go.

@PatrickMelia
Copy link

Does any one know how to get bootstrap date picker to work on all browsers? Or JQuery UI date picker to work bootstrap layout for mvc 4?

@twbs twbs locked and limited conversation to collaborators Jun 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests