Fix carousel controls styling consistency cross-platform #5083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes arrow in carousel controls on Windows being roughly double the size of the arrow on other platforms such as Mac which have Helvetica font installed, by forcing carousel controls to use Arial.
|
I'm fine with IE looking a bit different here. The carousel styling will change up in a coming release, so for now we'll leave it as is. Thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the size of the arrow in carousel controls on Windows being roughly double the size of the arrow on other platforms such as Mac because Helvetica is not installed by default on Windows. Usually falling back on Arial from Helvetica is fine, but the arrow's font-size is 60px and at that size the height of the font differs greatly.
By forcing the carousel controls to Arial at font-size 36px, we can have a consistent looking carousel control cross-platform.
Before commit: http://i.imgur.com/obRunh.jpg
After commit: http://i.imgur.com/dSqHIh.jpg